Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for 'more_io_inner_methods' #41519

Closed
SergioBenitez opened this issue Apr 24, 2017 · 6 comments
Closed

Tracking issue for 'more_io_inner_methods' #41519

SergioBenitez opened this issue Apr 24, 2017 · 6 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@SergioBenitez
Copy link
Contributor

Feature was added in #41463, resolving #29067.

This feature enables several internal accessor methods on structures in std::io including Take::{get_ref, get_mut} and Chain::{into_inner, get_ref, get_mut}.

cc @alexcrichton
@alexcrichton alexcrichton added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 25, 2017
@SergioBenitez SergioBenitez mentioned this issue May 19, 2017
Closed
11 tasks
@SergioBenitez
Copy link
Contributor Author

I'd like to propose that this be stabilized for 1.20. The added methods are rather uncontroversial: they simply expose the same type of behavior already exposed by other structures. As such, stabilizing these has little to no drawback. @brson, @alexcrichton

@alexcrichton
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jun 3, 2017 •
edited by brson
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 16, 2017
Closed
@rfcbot
Copy link

rfcbot commented Jun 21, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 21, 2017
@rfcbot
Copy link

rfcbot commented Jul 1, 2017

The final comment period is now complete.

@SergioBenitez
Copy link
Contributor Author

Stabilization PR is incoming.

@SergioBenitez SergioBenitez mentioned this issue Jul 1, 2017
Merged
bors added a commit that referenced this issue Jul 1, 2017
@bors
Auto merge of #43002 - SergioBenitez:more-io-inner-stable, r=BurntSushi
a19693a 
Stabilize 'more_io_inner_methods' feature.

As in the title. Closes #41519.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @SergioBenitez @rfcbot