Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal accessor methods to io::{Chain, Take}. #41463

Merged
merged 4 commits into from
Apr 26, 2017
Merged

Add internal accessor methods to io::{Chain, Take}. #41463

merged 4 commits into from
Apr 26, 2017

Conversation

SergioBenitez
Copy link
Contributor

Resolves #29067.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SergioBenitez
Copy link
Contributor Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned alexcrichton Apr 22, 2017
@SergioBenitez SergioBenitez force-pushed the master branch 3 times, most recently from 76df370 to daa74f7 Compare April 22, 2017 10:36
@frewsxcv frewsxcv added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 22, 2017
@bors
Copy link
Contributor

bors commented Apr 23, 2017

☔ The latest upstream changes (presumably #41437) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Looks good to me, thanks!

Could you also be sure to document on the get_mut case that care should be taken to not corrupt the stream? (e.g. doing your own reads/writes may mess up the internal state of these structs).

Other than r=me. Can you file a tracking issue and cc me? I'll be sure to tag it appropriately

@SergioBenitez SergioBenitez mentioned this pull request Apr 24, 2017
Closed
@SergioBenitez
Copy link
Contributor Author

SergioBenitez commented Apr 24, 2017 •
edited
Loading

Awesome, thanks @alexcrichton!

@aturon
Copy link
Member

aturon commented Apr 24, 2017

@bors: r=alexcrichton

(Need r+ rights for this).

@bors
Copy link
Contributor

bors commented Apr 24, 2017

📌 Commit f0fcbff has been approved by alexcrichton

@SergioBenitez
Copy link
Contributor Author

Ah, that makes sense. :) Thanks!

@alexcrichton
Copy link
Member

@bors: r-

oh looks like some of the issue references are still ="0"? though?

@alexcrichton alexcrichton reopened this Apr 25, 2017
@alexcrichton
Copy link
Member

oops didn't mean to close

@SergioBenitez
Copy link
Contributor Author

Ah, of course! Did indeed forget those. They're in now.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 25, 2017

📌 Commit c168d8b has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 25, 2017
@frewsxcv
Rollup merge of rust-lang#41463 - SergioBenitez:master, r=alexcrichton
4318c48 
Add internal accessor methods to io::{Chain, Take}.

Resolves rust-lang#29067.
@frewsxcv frewsxcv mentioned this pull request Apr 25, 2017
Closed
@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Rollup merge of rust-lang#41463 - SergioBenitez:master, r=alexcrichton
aee29a7 
Add internal accessor methods to io::{Chain, Take}.

Resolves rust-lang#29067.
@arielb1 arielb1 mentioned this pull request Apr 25, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Rollup merge of rust-lang#41463 - SergioBenitez:master, r=alexcrichton
9e6641a 
Add internal accessor methods to io::{Chain, Take}.

Resolves rust-lang#29067.
@arielb1 arielb1 mentioned this pull request Apr 25, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41463 - SergioBenitez:master, r=alexcrichton
5f62b27 
Add internal accessor methods to io::{Chain, Take}.

Resolves rust-lang#29067.
@frewsxcv frewsxcv mentioned this pull request Apr 26, 2017
Merged
bors added a commit that referenced this pull request Apr 26, 2017
@bors
Auto merge of #41551 - frewsxcv:rollup, r=frewsxcv
4512424 
Rollup of 9 pull requests

- Successful merges: #39983, #41442, #41463, #41500, #41518, #41527, #41528, #41530, #41535
- Failed merges:
@bors bors merged commit c168d8b into rust-lang:master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SergioBenitez @rust-highfive @bors @alexcrichton @aturon @frewsxcv @arielb1