Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 2421, "Keyword unreservations (pure, sizeof, alignof, offsetof)" #51115

Closed
1 of 2 tasks
Centril opened this issue May 27, 2018 · 5 comments
Closed
1 of 2 tasks
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented May 27, 2018

This is a tracking issue for the RFC "Keyword unreservations (pure, sizeof, alignof, offsetof)" (rust-lang/rfcs#2421).

Steps:

Unresolved questions:

None

@Centril Centril added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-lang Relevant to the language team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels May 27, 2018
@Havvy
Copy link
Contributor

Havvy commented May 27, 2018

I'm going to tackle this one.

@Havvy
Copy link
Contributor

Havvy commented May 28, 2018

Do I remove the file as per the previous PR, or do I change the expected error message?

unexpected errors (from JSON output): [
    Error {
        line_num: 13,
        kind: Some(
            Error
        ),
        msg: "13:6: 13:8: expected one of `!` or `::`, found `fn`"
    }
]

not found errors (from test file): [
    Error {
        line_num: 13,
        kind: Some(
            Error
        ),
        msg: "expected item, found `pure`"
    }
]

@Havvy
Copy link
Contributor

Havvy commented May 28, 2018

The file code is just pure fn foo() {}

@Centril
Copy link
Contributor Author

Centril commented Jul 12, 2018

Should this be closed now?

@Centril
Copy link
Contributor Author

Centril commented Aug 8, 2018

This is stable now; closing..

@Centril Centril closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants