Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof) #51196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I would add some tests checking that the removed reservations now work as identifiers. Also, reassigning to :) |
|
Triage ping, @petrochenkov. This PR is waiting for your review. |
|
@bors r+ |
|
📌 Commit 8bb7817 has been approved by |
bors
added
S-waiting-on-bors
Centril
added
the
relnotes
|
🔒 Merge conflict |
bors
added
S-waiting-on-author
|
Rebased onto master to get rid of merge conflict. No actual code changes. |
|
I think this is waiting for a new r+? |
|
@bors r+ |
|
📌 Commit 679a521 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 10, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof) On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works. I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
|
☀️ Test successful - status-appveyor, status-travis |
linouxis9
pushed a commit
to rust3ds/ctr-std-horizon
that referenced
this pull request
Jun 10, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof) On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works. I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
ischeinkman
pushed a commit
to ischeinkman/libnx-rs-std
that referenced
this pull request
Sep 26, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof) On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works. I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
carols10cents
added a commit
to rust-lang/book
that referenced
this pull request
Oct 23, 2018
These were removed in rust-lang/rust#51196
ischeinkman
pushed a commit
to ischeinkman/libnx-rs-std
that referenced
this pull request
Dec 20, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof) On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works. I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my local machine I was getting failures in
test/ui-fulldeps, but I was also getting them again after reverting the change, so I'm hoping that this works.I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.