Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof) #51196

Merged
merged 2 commits into from
Jun 10, 2018

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented May 30, 2018

On my local machine I was getting failures in test/ui-fulldeps, but I was also getting them again after reverting the change, so I'm hoping that this works.

I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2018
@Havvy
Copy link
Contributor Author

Havvy commented Jun 1, 2018

Tracking issue: #51115

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned aturon Jun 1, 2018
@Centril
Copy link
Contributor

Centril commented Jun 1, 2018

I would add some tests checking that the removed reservations now work as identifiers.
Looks good otherwise.

Also, reassigning to

r? @petrochenkov

:)

@TimNN
Copy link
Contributor

TimNN commented Jun 5, 2018

Triage ping, @petrochenkov. This PR is waiting for your review.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2018

📌 Commit 8bb7817 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2018
@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 9, 2018
@bors
Copy link
Contributor

bors commented Jun 9, 2018

🔒 Merge conflict

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2018
@Havvy
Copy link
Contributor Author

Havvy commented Jun 9, 2018

Rebased onto master to get rid of merge conflict. No actual code changes.

@Havvy
Copy link
Contributor Author

Havvy commented Jun 10, 2018

I think this is waiting for a new r+?

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2018

📌 Commit 679a521 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2018
@bors
Copy link
Contributor

bors commented Jun 10, 2018

⌛ Testing commit 679a521 with merge 684b8d3...

bors added a commit that referenced this pull request Jun 10, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof)

On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works.

I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
@bors
Copy link
Contributor

bors commented Jun 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 684b8d3 to master...

@bors bors merged commit 679a521 into rust-lang:master Jun 10, 2018
linouxis9 pushed a commit to rust3ds/ctr-std-horizon that referenced this pull request Jun 10, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof)

On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works.

I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
@Havvy Havvy deleted the remove-keywords branch June 11, 2018 07:48
ischeinkman pushed a commit to ischeinkman/libnx-rs-std that referenced this pull request Sep 26, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof)

On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works.

I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
carols10cents added a commit to rust-lang/book that referenced this pull request Oct 23, 2018
ischeinkman pushed a commit to ischeinkman/libnx-rs-std that referenced this pull request Dec 20, 2018
Implement RFC 2421, 'Keyword unreservations (pure, sizeof, alignof, offsetof)

On my local machine I was getting failures in `test/ui-fulldeps`, but I was also getting them again after reverting the change, so I'm hoping that this works.

I removed the test because that's what the other PR that unreserved a keyword did and I feel that it doesn't make sense/keep value to keep a test for something removed years ago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants