Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'proc' from the reserved keywords list #49699

Merged
merged 4 commits into from
Apr 17, 2018
Merged

Removed 'proc' from the reserved keywords list #49699

merged 4 commits into from
Apr 17, 2018

Conversation

zesterer
Copy link
Contributor

@zesterer zesterer commented Apr 5, 2018

Remove 'proc' from the reserved keywords list.

'proc' is a very useful identifier name for a lot of things. It's especially useful when dealing with processes, operating system internals, and kernel development.

@TimNN
Copy link
Contributor

TimNN commented Apr 5, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Resolving deltas: 100% (607640/607640), completed with 4796 local objects.
---
[00:01:00] configure: rust.quiet-tests     := True
---
[00:20:07] error: can't qualify macro invocation with `pub`
[00:20:07]    --> libcore/mem.rs:950:1
[00:20:07]     |
[00:20:07] 950 | pub union ManuallyDrop<T>{ value: T }
[00:20:07]     | ^^^
[00:20:07]     |
[00:20:07]     = help: try adjusting the macro to put `pub` inside the invocation
[00:20:07]
[00:20:07] error: expected one of `!` or `::`, found `ManuallyDrop`
[00:20:07]    --> libcore/mem.rs:950:11
[00:20:07]     |
[00:20:07] 950 | pub union ManuallyDrop<T>{ value: T }
[00:20:07]     |           ^^^^^^^^^^^^ expected one of `!` or `::` here
---
[00:20:07]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name core libcore/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=64878136ec7adadb -C extra-filename=-64878136ec7adadb --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps` (exit code: 101)
[00:20:07] warning: build failed, waiting for other jobs to finish...
[00:20:13] error: build failed
[00:20:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:20:13] expected success, got: exit code: 101
[00:20:13] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1085:9
[00:20:13] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:20:13] travis_fold:end:stage1-std
[00:20:13] travis_time:end:stage1-std:start=1522952697539010157,finish=1522952704299775411,duration=6760765254
[00:20:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:20:13] Build completed unsuccessfully in 0:15:23
[00:20:13] make: *** [all] Error 1
[00:20:13] Makefile:28: recipe for target 'all' failed
---
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:24036f96:start=1522952704994629569,finish=1522952705001253890,duration=6624321
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:072af594
$ dmesg | grep -i kill
[   10.255160] init: failsafe main process (1092) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@steveklabnik steveklabnik added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 5, 2018
@TimNN
Copy link
Contributor

TimNN commented Apr 5, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Resolving deltas: 100% (607638/607638), completed with 4801 local objects.
---
[00:00:43] configure: rust.quiet-tests     := True
---
[00:18:10] error: can't qualify macro invocation with `pub`
[00:18:10]    --> libcore/mem.rs:950:1
[00:18:10]     |
[00:18:10] 950 | pub union ManuallyDrop<T>{ value: T }
[00:18:10]     | ^^^
[00:18:10]     |
[00:18:10]     = help: try adjusting the macro to put `pub` inside the invocation
[00:18:10]
[00:18:10] error: expected one of `!` or `::`, found `ManuallyDrop`
[00:18:10]    --> libcore/mem.rs:950:11
[00:18:10]     |
[00:18:10] 950 | pub union ManuallyDrop<T>{ value: T }
[00:18:10]     |           ^^^^^^^^^^^^ expected one of `!` or `::` here
---
[00:18:10]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name core libcore/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=64878136ec7adadb -C extra-filename=-64878136ec7adadb --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps` (exit code: 101)
[00:18:10] warning: build failed, waiting for other jobs to finish...
[00:18:15] error: build failed
[00:18:15] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:18:15] expected success, got: exit code: 101
[00:18:15] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1085:9
[00:18:15] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:18:15] travis_fold:end:stage1-std
[00:18:15] travis_time:end:stage1-std:start=1522963695553540715,finish=1522963701150493280,duration=5596952565
[00:18:15] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:18:15] Build completed unsuccessfully in 0:14:07
[00:18:15] make: *** [all] Error 1
[00:18:15] Makefile:28: recipe for target 'all' failed
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:0cb1a874:start=1522963701690521162,finish=1522963701696383041,duration=5861879
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:00278c08
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSi

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@kennytm kennytm added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Apr 5, 2018
@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2018
@shepmaster
Copy link
Member

Thanks for your PR! We'll make sure to get a top-notch reviewer on the case as soon as possible!

Randomly assigning...

r? @joshtriplett

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2018

📌 Commit 5e94d54 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2018
@bors
Copy link
Contributor

bors commented Apr 8, 2018

⌛ Testing commit 5e94d54 with merge 58ba05d572989b1c57151b256de4c164befe88fd...

@bors
Copy link
Contributor

bors commented Apr 8, 2018

💔 Test failed - status-travis

@TimNN
Copy link
Contributor

TimNN commented Apr 8, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:23:29] error: can't qualify macro invocation with `pub`
[00:23:29]    --> libcore/mem.rs:950:1
[00:23:29]     |
[00:23:29] 950 | pub union ManuallyDrop<T>{ value: T }
[00:23:29]     | ^^^
[00:23:29]     |
[00:23:29]     = help: try adjusting the macro to put `pub` inside the invocation
[00:23:29]
[00:23:29] error: expected one of `!` or `::`, found `ManuallyDrop`
[00:23:29]    --> libcore/mem.rs:950:11
[00:23:29]     |
[00:23:29] 950 | pub union ManuallyDrop<T>{ value: T }
[00:23:29]     |           ^^^^^^^^^^^^ expected one of `!` or `::` here
---
[00:23:29]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name core libcore/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=64878136ec7adadb -C extra-filename=-64878136ec7adadb --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps` (exit code: 101)
[00:23:29] warning: build failed, waiting for other jobs to finish...
[00:23:36] error: build failed
[00:23:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:23:36] expected success, got: exit code: 101
[00:23:36] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1085:9
[00:23:36] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:23:36] travis_fold:end:stage1-std
[00:23:36] travis_time:end:stage1-std:start=1523147249191398064,finish=1523147256197301359,duration=7005903295
[00:23:36] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:23:36] Build completed unsuccessfully in 0:18:19
[00:23:36] Makefile:28: recipe for target 'all' failed
[00:23:36] make: *** [all] Error 1
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:00a62472:start=1523147256869234073,finish=1523147256876769971,duration=7535898
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:24bb66da
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:24bb66da:start=1523147256888724724,finish=1523147256896296045,duration=7571321
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a45dac0
$ dmesg | grep -i kill
[   11.010625] init: failsafe main process (1095) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2018
@TimNN
Copy link
Contributor

TimNN commented Apr 8, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:23:29] error: can't qualify macro invocation with `pub`
[00:23:29]    --> libcore/mem.rs:950:1
[00:23:29]     |
[00:23:29] 950 | pub union ManuallyDrop<T>{ value: T }
[00:23:29]     | ^^^
[00:23:29]     |
[00:23:29]     = help: try adjusting the macro to put `pub` inside the invocation
[00:23:29]
[00:23:29] error: expected one of `!` or `::`, found `ManuallyDrop`
[00:23:29]    --> libcore/mem.rs:950:11
[00:23:29]     |
[00:23:29] 950 | pub union ManuallyDrop<T>{ value: T }
[00:23:29]     |           ^^^^^^^^^^^^ expected one of `!` or `::` here
---
[00:23:29]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name core libcore/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=64878136ec7adadb -C extra-filename=-64878136ec7adadb --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps` (exit code: 101)
[00:23:29] warning: build failed, waiting for other jobs to finish...
[00:23:36] error: build failed
[00:23:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:23:36] expected success, got: exit code: 101
[00:23:36] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1085:9
[00:23:36] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:23:36] travis_fold:end:stage1-std
[00:23:36] travis_time:end:stage1-std:start=1523147249191398064,finish=1523147256197301359,duration=7005903295
[00:23:36] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:23:36] Build completed unsuccessfully in 0:18:19
[00:23:36] Makefile:28: recipe for target 'all' failed
[00:23:36] make: *** [all] Error 1
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:00a62472:start=1523147256869234073,finish=1523147256876769971,duration=7535898
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:24bb66da
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:24bb66da:start=1523147256888724724,finish=1523147256896296045,duration=7571321
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a45dac0
$ dmesg | grep -i kill
[   11.010625] init: failsafe main process (1095) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@@ -318,7 +318,6 @@ declare_keywords! {
(46, Offsetof, "offsetof")
(47, Override, "override")
(48, Priv, "priv")
(49, Proc, "proc")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyword list shouldn't contain holes (otherwise random identifiers will be interpreted as keywords), so the numbers of following keywords have to be shifted by one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. @zesterer?

(Also, I wonder if we could construct this list in another way so that it auto-numbers, eliminating this issue in the future.)

Copy link
Contributor Author

@zesterer zesterer Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshtriplett My experience with the compiler codebase is less than excellent. Is this the sort of thing that could be easily macro-driven?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only keyword removed in the last 3-4 years, certainly not something that need to be automated by extra macro machinery.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrochenkov I may be over-thinking this. Is this literally just a case of enumerating everything that comes after the removed keyword?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zesterer
Yes

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2018
@Mark-Simulacrum
Copy link
Member

Should we perhaps go through approval from all of lang team before merging this? Seems like a semi-major change (removing a keyword)...

@zesterer
Copy link
Contributor Author

You said you wanted to be included in this, @nikomatsakis ?

@TimNN
Copy link
Contributor

TimNN commented Apr 11, 2018

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Resolving deltas: 100% (613192/613192), completed with 4865 local objects.
---
[00:00:51] configure: rust.quiet-tests     := True
---
[00:41:09] ..............................................................................i.....................
[00:41:15] .....................i..............................................................................
---
[00:41:55] i..........................................................................i........................
---
[00:42:46] .............................................i......................................................
---
[00:46:21] .............................i......................................................................
[00:46:34] ..............................................................i.....................................
[00:46:49] ...............................................i....................................................
[00:47:07] ....................................................................................................
[00:47:28] ....................................................................................................
[00:47:47] ....................................................................................................
[00:48:11] ...i...............................................................................................i
[00:48:40] ............................................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:48:44] ........
[00:49:13] ....................................................................................................
[00:49:45] .................................................................ii.................................
[00:50:33] ............................i....................................................i.ii...............
[00:50:33] test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:51:10] .........................................................................................iiiiiii....
---
[00:53:17] ...................i............................................................ii.iii..............
[00:53:24] ....................................................................................................
[00:53:31] .........i..............................i...........................................................
[00:53:38] ....................................................................................................
[00:53:45] .....................i..............................................................................
[00:53:52] ....................................................................................................
[00:54:02] ....................................................................................................
[00:54:11] ....................................................................................................
[00:54:22] ....................................................................................................
[00:54:34] ....................................................................................................
[00:54:42] ..............i.....................................................................................
[00:54:50] ..................i..ii.............................................................................
[00:55:00] ....................................................................................................
[00:55:09] ....................................................................................................
[00:55:18] .....................................................................................i..............
[00:55:28] ...............................i....................................................................
---
[00:56:03] ...........................i........................................................................
[00:56:04] ....................................................................i...............F...............
[00:56:05] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:486:22
[00:56:05] ................i.......................................................
[00:56:05] failures:
[00:56:05]
[00:56:05] ---- [parse-fail] parse-fail/obsolete-proc.rs stdout ----
[00:56:05]
[00:56:05] error: /checkout/src/test/parse-fail/obsolete-proc.rs:17: unexpected error: '17:19: 17:20: expected one of `.`, `;`, `?`, `}`, or an operator, found `1`'
[00:56:05]
[00:56:05] error: /checkout/src/test/parse-fail/obsolete-proc.rs:15: expected error not found: expected type, found reserved keyword `proc`
[00:56:05]
[00:56:05] error: /checkout/src/test/parse-fail/obsolete-proc.rs:17: expected error not found: expected expression, found reserved keyword `proc`
[00:56:05]
[00:56:05] error: 1 unexpected errors found, 2 expected errors not found
[00:56:05] status: exit code: 101
[00:56:05] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/parse-fail/obsolete-proc.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/parse-fail" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/parse-fail/obsolete-proc.stage2-x86_64-unknown-linux-gnu" "-Crpath" "-O" "-Zmiri" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "parse-only" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/parse-fail/obsolete-proc.stage2-x86_64-unknown-linux-gnu.aux"
[00:56:05] unexpected errors (from JSON output): [
[00:56:05]     Error {
[00:56:05]         line_num: 17,
[00:56:05]         kind: Some(
[00:56:05]             Error
[00:56:05]         ),
[00:56:05]         msg: "17:19: 17:20: expected one of `.`, `;`, `?`, `}`, or an operator, found `1`"
---
[00:56:05]         msg: "expected type, found reserved keyword `proc`"
---
[00:56:05]         msg: "expected expression, found reserved keyword `proc`"
---
[00:56:05] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/parse-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/parse-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "parse-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zmiri -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zmiri -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:56:05] expected success, got: exit code: 101
[00:56:05]
[00:56:05]
[00:56:05] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:56:05] Build completed unsuccessfully in 0:16:04
[00:56:05] Makefile:58: recipe for target 'check' failed
[00:56:05] make: *** [check] Error 1
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:0057a134:start=1523453219592337856,finish=1523453219599136248,duration=6798392
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:0c081e41
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:0c081e41:start=1523453219604864538,finish=1523453219611116032,duration=6251494
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:11526921
$ dmesg | grep -i kill
[   11.826533] init: failsafe main process (1094) killed by TERM signal
[   43.427431] init: plymouth-upstart-bridge main process (510) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kngwyu
Copy link
Contributor

kngwyu commented Apr 12, 2018

Isn't it good to note that this change is based on #19338?

@pietroalbini pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2018
@pietroalbini
Copy link
Member

Ping from triage @joshtriplett! The author addressed the comments in this PR, could you review it again?

@joshtriplett
Copy link
Member

Thanks for the updates; LGTM.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2018

📌 Commit 7f58d2f has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2018
@aturon
Copy link
Member

aturon commented Apr 16, 2018

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 17, 2018
Removed 'proc' from the reserved keywords list

Remove 'proc' from the reserved keywords list.

'proc' is a very useful identifier name for a lot of things. It's especially useful when dealing with processes, operating system internals, and kernel development.
bors added a commit that referenced this pull request Apr 17, 2018
Rollup of 4 pull requests

Successful merges:

 - #49699 (Removed 'proc' from the reserved keywords list)
 - #49966 (Multiple query search)
 - #50013 (Remove no longer necessary comparison to Vec::splice.)
 - #50032 (rustdoc: Don't include private paths in all.html)

Failed merges:
@bors bors merged commit 7f58d2f into rust-lang:master Apr 17, 2018
Havvy added a commit to Havvy/reference that referenced this pull request Apr 24, 2018
@aturon
Copy link
Member

aturon commented Apr 25, 2018

cc @rust-lang/lang @Centril This PR really needed an RFC, or at the very least an FCP step from the lang team (AFAIK the change has not been approved elsewhere). Not sure whether we want to take further action here?

@Centril
Copy link
Contributor

Centril commented Apr 25, 2018

I can have an RFC ready tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.