Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::hashmap should use TotalEq #5283

Closed
thestinger opened this issue Mar 8, 2013 · 3 comments · Fixed by #13088
Closed

std::hashmap should use TotalEq #5283

thestinger opened this issue Mar 8, 2013 · 3 comments · Fixed by #13088
Milestone
1.0

Comments

@thestinger
Copy link
Contributor

This would avoid the problem discussed in #4510 by just not using partial ordering as a way to implement maps.
@ghost ghost assigned thestinger Mar 9, 2013
@nikomatsakis nikomatsakis mentioned this issue Mar 10, 2013
Closed
@catamorphism
Copy link
Contributor

Still an issue.

1 similar comment
@emberian
Copy link
Member

emberian commented Aug 1, 2013

Still an issue.

@dredozubov dredozubov mentioned this issue Nov 23, 2013
Closed
@thestinger
Copy link
Contributor Author

See #10320, another potential solution.

@erickt erickt mentioned this issue Feb 20, 2014
Closed
3 tasks
This was referenced Feb 21, 2014
Closed
Closed
@thestinger thestinger mentioned this issue Mar 22, 2014
Merged
bors added a commit that referenced this issue Mar 23, 2014
@bors
auto merge of #13088 : thestinger/rust/hashmap, r=cmr
2ddb605 
Closes #5283
@thestinger thestinger removed their assignment Jun 16, 2014
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@matthiaskrgr
don't emit lifetime lints for code inside macros.
8e83afa 
Fixes rust-lang#5283
bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5293 - matthiaskrgr:macro_skip_lifetime, r=ph…
1cac2f9 
…ansch

don't emit lifetime lint warnings for code inside macros.

Fixes rust-lang#5283

changelog: Don't emit lifetime lint warnings for code inside macros.
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 10, 2023
@bors
Auto merge of rust-lang#10257 - tylerjw:issue_5283, r=flip1995
e1224cd 
needless_lifetimes: lint local macros

fixes rust-lang#5283

changelog: [`needless_lifetimes`]: lint local macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

use TotalEq for HashMap
require a total ordering for Eq and Ord
3 participants
@catamorphism @emberian @thestinger