enforce HashMap to use TotalEq #10619
Conversation
|
This doesn't change the bound on the key type to |
|
@thestinger Hm, seems like i totally misunderstood the problem. So, we're basically looking for |
|
Yeah, but I'm not sure if it's the right way forward. It would be easier to just remove the |
|
Closing due to a lack of activity. This is a fairly fundamental change which may also require rethinking of whether TotalEq is necessary to have in tandem with Eq. Additionally, I believe the intent of the original bug was to replace the Eq bound with TotalEq rather than implementing TotalEq on hash maps. |
fix(generate_method): correct method indentation inside generated impl and change gen loc should fix rust-lang#10619
Show interior mutability chain in `mutable_key_type` Fixes rust-lang#10619 Just ran into this myself and I definitely agree it's not very nice to have to manually go through all the types involved to figure out why this happens and to evaluate if this is really a problem (knowing if the field of a struct is something that a hash impl relies on), so this changes the lint to emit notes for each step involved. changelog: none
discussed in #5283 and #4510
Seemed pretty straightforard, can anyone give it a look?