Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: const_maybe_uninit_as_ptr) #75251

Closed
2 of 3 tasks
RalfJung opened this issue Aug 7, 2020 · 14 comments
Closed
2 of 3 tasks

Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: const_maybe_uninit_as_ptr) #75251

RalfJung opened this issue Aug 7, 2020 · 14 comments
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Aug 7, 2020 •
edited
Loading

This is a tracking issue for const MaybeUninit::as(_mut)_ptr.
The feature gate for the issue is #![feature(const_maybe_uninit_as_ptr)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

Implementation history
@RalfJung RalfJung added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Aug 7, 2020
@RalfJung RalfJung changed the title Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: maybe_uninit_const_as_ptr) Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: const_) Aug 7, 2020
@RalfJung RalfJung changed the title Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: const_) Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: const_maybe_uninit_const_as_ptr) Aug 7, 2020
@RalfJung RalfJung changed the title Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: const_maybe_uninit_const_as_ptr) Tracking Issue for const MaybeUninit::as(_mut)_ptr (feature: const_maybe_uninit_as_ptr) Aug 7, 2020
@jhpratt
Copy link
Member

jhpratt commented Oct 19, 2021

There doesn't appear to be any blockers for the non-mut version, unless I'm missing something?

@lilasta lilasta mentioned this issue Mar 6, 2022
Closed
3 tasks
@pnkfelix
Copy link
Member

Visiting for T-compiler backlog bonanza. This seems likely to be ready to stabilize, but since I'm not certain, I'm tagging with "needs summary"

Also, we think the question of whether to stabilize these methods falls under T-libs domain, so tagging with that team label

@rustbot label: +T-libs +S-tracking-needs-summary

@rustbot rustbot added S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 23, 2022
@pnkfelix pnkfelix added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 23, 2022
@m-ou-se m-ou-se removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 23, 2022
@pnkfelix
Copy link
Member

(@m-ou-se pointed out that this is a libs-api team issue, not a libs implementation issue.)

@m-ou-se
Copy link
Member

m-ou-se commented Sep 23, 2022

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Sep 23, 2022 •
edited by BurntSushi
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 23, 2022
@RalfJung
Copy link
Member Author

Cc @rust-lang/wg-const-eval but this should be uncontroversial

@fee1-dead
Copy link
Member

No concerns with this.

@dtolnay
Copy link
Member

dtolnay commented Dec 20, 2022

I'm marking @yaahc's box because she has stepped down from T-libs-api after the point that this feature got proposed for FCP.

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Dec 20, 2022
@rfcbot
Copy link

rfcbot commented Dec 20, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 20, 2022
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 30, 2022
@rfcbot
Copy link

rfcbot commented Dec 30, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Dec 30, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 12, 2023
@Noratrieb
Copy link
Member

Status: as_ptr has been stabilized. as_mut_ptr is blocked on #57349

@RalfJung
Copy link
Member Author

RalfJung commented Sep 6, 2024

@rust-lang/libs-api with #57349 no longer being a blocker, are you fine with MaybeUninit::as_mut_ptr being const-stabilized under the above FCP?

@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 6, 2024
@Amanieu
Copy link
Member

Amanieu commented Sep 17, 2024

We discussed this in the libs-api meeting and we're happy to keep the existing FCP for as_mut_ptr.

@Amanieu Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 17, 2024
@ultrabear ultrabear mentioned this issue Sep 19, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 19, 2024
@workingjubilee
Rollup merge of rust-lang#130542 - ultrabear:stabilize_const_maybeuni…
cfa2951 
…nit_as_mut_ptr, r=workingjubilee

Stabilize const `MaybeUninit::as_mut_ptr`

This PR stabilizes the following APIs as const stable as of rust `1.83`:
```rs
impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}
```
This is made possible by const_mut_refs being stabilized (yay).

FCP: rust-lang#75251 [(comment)](rust-lang#75251 (comment))
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 19, 2024
@workingjubilee
Rollup merge of rust-lang#130542 - ultrabear:stabilize_const_maybeuni…
0ad2a52 
…nit_as_mut_ptr, r=workingjubilee

Stabilize const `MaybeUninit::as_mut_ptr`

This PR stabilizes the following APIs as const stable as of rust `1.83`:
```rs
impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}
```
This is made possible by const_mut_refs being stabilized (yay).

FCP: rust-lang#75251 [(comment)](rust-lang#75251 (comment))
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 19, 2024
@rust-timer
Unrolled build for rust-lang#130542
123321b 
Rollup merge of rust-lang#130542 - ultrabear:stabilize_const_maybeuninit_as_mut_ptr, r=workingjubilee

Stabilize const `MaybeUninit::as_mut_ptr`

This PR stabilizes the following APIs as const stable as of rust `1.83`:
```rs
impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}
```
This is made possible by const_mut_refs being stabilized (yay).

FCP: rust-lang#75251 [(comment)](rust-lang#75251 (comment))
@RalfJung
Copy link
Member Author

This is closed by #130542 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests