Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize const MaybeUninit::as_mut_ptr #130542

Merged

Conversation

ultrabear
Copy link
Contributor

This PR stabilizes the following APIs as const stable as of rust 1.83:

impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}

This is made possible by const_mut_refs being stabilized (yay).

FCP: #75251 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 19, 2024
@rust-log-analyzer

This comment has been minimized.

@workingjubilee
Copy link
Member

New API, as noted libs-api has decided this one doesn't need a new FCP.

@rustbot label: relnotes

@bors r+

@bors
Copy link
Contributor

bors commented Sep 19, 2024

📌 Commit b7ca2b6 has been approved by workingjubilee

It is now in the queue for this repository.

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 19, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 19, 2024
…nit_as_mut_ptr, r=workingjubilee

Stabilize const `MaybeUninit::as_mut_ptr`

This PR stabilizes the following APIs as const stable as of rust `1.83`:
```rs
impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}
```
This is made possible by const_mut_refs being stabilized (yay).

FCP: rust-lang#75251 [(comment)](rust-lang#75251 (comment))
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2024
…kingjubilee

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130531 (Check params for unsafety in THIR)
 - rust-lang#130533 (Never patterns constitute a read for unsafety)
 - rust-lang#130542 (Stabilize const `MaybeUninit::as_mut_ptr`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0ad2a52 into rust-lang:master Sep 19, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2024
Rollup merge of rust-lang#130542 - ultrabear:stabilize_const_maybeuninit_as_mut_ptr, r=workingjubilee

Stabilize const `MaybeUninit::as_mut_ptr`

This PR stabilizes the following APIs as const stable as of rust `1.83`:
```rs
impl<T> MaybeUninit<T> {
    pub const fn as_mut_ptr(&mut self) -> *mut T;
}
```
This is made possible by const_mut_refs being stabilized (yay).

FCP: rust-lang#75251 [(comment)](rust-lang#75251 (comment))
@rustbot rustbot added this to the 1.83.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants