-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc-gui tests sporadically failing #93784
Comments
That is concerning... If it happens too many times, let's revert it. |
…st, r=notriddle Update browser UI test version Might help a bit with rust-lang#93784 (still need to figure out what's going on with the driver). r? `@notriddle`
…st, r=notriddle Update browser UI test version Might help a bit with rust-lang#93784 (still need to figure out what's going on with the driver). r? ``@notriddle``
…st, r=notriddle Update browser UI test version Might help a bit with rust-lang#93784 (still need to figure out what's going on with the driver). r? ```@notriddle```
There is also #94417. |
It looks like rustdoc-gui tests are now consistently failing with:
|
I'm checking locally. |
…st, r=notriddle Update browser-ui-test version It should help with rust-lang#93784 (the important PR helping in this regard is GuillaumeGomez/browser-UI-test#273). r? `@notriddle`
@ehuss Is it still the case? |
It seems to still be happening regularly: 2021-11-23T17:42:34 https://github.com/rust-lang-ci/rust/actions/runs/1495820343: [ERROR] (line 4) TimeoutError: waiting for selector |
The situation seems to have been much better since #95013: there is just one error to fix now. \o/ |
…t, r=notriddle Fix last rustdoc-gui spurious test This should the last spurious failing GUI test from rust-lang#93784. r? `@notriddle`
…t, r=notriddle Fix last rustdoc-gui spurious test This should the last spurious failing GUI test from rust-lang#93784. r? ``@notriddle``
@GuillaumeGomez Just FYI, there's still timeouts happening after #95470:
https://github.com/rust-lang-ci/rust/actions/runs/2086146075 |
Thanks! Then I'll need for another way to wait for the search results. |
Nevermind, seems like new bugs appeared recently. I'll take another look. |
A new spurious failure appeared in #102744. |
…est, r=notriddle Update browser-ui-test version to fix some flaky tests Part of rust-lang#93784. It should fix the new spurious failure found in rust-lang#102744. r? `@notriddle`
…est, r=notriddle Update browser-ui-test version to fix some flaky tests Part of rust-lang#93784. It should fix the new spurious failure found in rust-lang#102744. r? ``@notriddle``
Another flaky GUI test #104647 (comment) |
That was
|
It seems to be mostly:
|
So about "execution context was destroyed": it seems that when puppeteer gets a element from the DOM, it can get destroyed in the meantime (for whatever reason), resulting in the current issue. A solution would be to instead move everything directly into the browser context. I'll check that in the next weeks to see if it improves the situation. |
…est, r=notriddle Update browser-ui-test version to reduce GUI tests flakyness Part of rust-lang#93784. r? `@notriddle`
Same spurious failure in #106315. So my fix didn't solve this issue unfortunately... |
…hanism, r=Mark-Simulacrum Add retry mechanism for rustdoc GUI tests to reduce flakyness Part of rust-lang#93784. I added 3 retries for failing GUI tests. An important note: if more than half of total tests fail, I don't retry because it's very likely not flakyness anymore at this point but a missing update after changes.
…tion-bug, r=notriddle Fix GUI test navigation bug Following GuillaumeGomez/browser-UI-test#438, we can now remove this `wait-for`. Should help with rust-lang#93784. r? `@notriddle`
…tion-bug, r=notriddle Fix GUI test navigation bug Following GuillaumeGomez/browser-UI-test#438, we can now remove this `wait-for`. Should help with rust-lang#93784. r? ``@notriddle``
The
src/test/rustdoc-gui
tests have been sporadically failing on CI:These may have started with #93597
cc @GuillaumeGomez
There are various different errors:
The text was updated successfully, but these errors were encountered: