Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM submodule #94764

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Update LLVM submodule #94764

merged 3 commits into from
Mar 10, 2022

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Mar 9, 2022

This merges upstream changes from the 14.x release branch.

Fixes #89609.
Fixes #93923.
Fixes #94032.

@nikic
Update LLVM submodule
8a0045f
@nikic
Use new pass manager on s390x with LLVM 14
0c7d0a1 
The problematic compile-time issue should be resolved with this
version.
@nikic
Enable issue-23036.rs on wasm32
6c58b5e
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2022
@nikic
Copy link
Contributor Author

nikic commented Mar 9, 2022

@bors try @rust-timer queue Perf impact expected because this merge also contains some optimization backports.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 9, 2022
@bors
Copy link
Contributor

bors commented Mar 9, 2022

⌛ Trying commit 6c58b5e with merge 002000a13a08597104ee4cf6511351a8f48e8b30...

@nikic nikic added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 9, 2022
@nikic nikic mentioned this pull request Mar 9, 2022
Closed
@bors
Copy link
Contributor

bors commented Mar 9, 2022

☀️ Try build successful - checks-actions
Build commit: 002000a13a08597104ee4cf6511351a8f48e8b30 (002000a13a08597104ee4cf6511351a8f48e8b30)

@rust-timer
Copy link
Collaborator

Queued 002000a13a08597104ee4cf6511351a8f48e8b30 with parent 6045c34, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (002000a13a08597104ee4cf6511351a8f48e8b30): comparison url.

Summary: This benchmark run did not return any relevant results. 62 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 9, 2022
@nagisa
Copy link
Member

nagisa commented Mar 9, 2022

Ugh, github has become even worse at showing just how exactly the submodule was updated :/

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2022

📌 Commit 6c58b5e has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
@lcnr
Copy link
Contributor

lcnr commented Mar 9, 2022

r? @nagisa

@lcnr lcnr closed this Mar 9, 2022
@lcnr lcnr reopened this Mar 9, 2022
@lcnr
Copy link
Contributor

lcnr commented Mar 9, 2022

woops, wrong button 😅 sry

@rust-highfive rust-highfive assigned nagisa and unassigned lcnr Mar 9, 2022
@nagisa
Copy link
Member

nagisa commented Mar 9, 2022

@bors r+

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
@bors
Copy link
Contributor

bors commented Mar 10, 2022

⌛ Testing commit 6c58b5e with merge 44849b685fbbe7dff90eba43cfefcb13c247a2dc...

@bors
Copy link
Contributor

bors commented Mar 10, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (60/61)
.          (61/61)


/checkout/src/test/rustdoc-gui/toggle-docs.goml An exception occured: Failed to launch the browser process!
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!


TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md
== STACKTRACE ==
Error
Error
    at innerRunTestCode (/node-v14.4.0-linux-x64/lib/node_modules/browser-ui-test/src/index.js:468:16)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

@nikic
Copy link
Contributor Author

nikic commented Mar 10, 2022

@bors retry That assertion is one of the spurious failures listed on #93784.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2022
@bors
Copy link
Contributor

bors commented Mar 10, 2022

⌛ Testing commit 6c58b5e with merge 282778a...

@bors
Copy link
Contributor

bors commented Mar 10, 2022

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 282778a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 10, 2022
@bors bors merged commit 282778a into rust-lang:master Mar 10, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 10, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (282778a): comparison url.

Summary: This benchmark run did not return any relevant results. 45 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@nikic nikic mentioned this pull request Mar 10, 2022
Closed
@apiraino
Copy link
Contributor

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 10, 2022
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 14, 2022
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.61.0, 1.60.0 Mar 14, 2022
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2022
@bors
Auto merge of rust-lang#94933 - Mark-Simulacrum:beta-next, r=Mark-Sim…
99f967e 
…ulacrum

[beta] backports

* Update LLVM submodule rust-lang#94764
* Statically compile libstdc++ everywhere if asked rust-lang#94719
* Downgrade #[test] on macro call to warning rust-lang#94624
* Delay bug in expr adjustment when check_expr is called multiple times rust-lang#94596
* bootstrap: correct reading of flags for llvm rust-lang#94466
* Check method input expressions once rust-lang#94438
* remove feature gate in control_flow examples rust-lang#94283

r? `@Mark-Simulacrum`
cuviper added a commit to cuviper/primal that referenced this pull request Mar 18, 2022
@cuviper
Revert "Temporarily ignore i686 bench"
3ea14d2 
This reverts commit 9da74e7.

The codegen issue was fixed by updates to LLVM 14, rust-lang/rust#94764.
@cuviper cuviper mentioned this pull request Mar 18, 2022
Merged
bors bot added a commit to huonw/primal that referenced this pull request Mar 18, 2022
@bors @cuviper
Merge #39
e520628 
39: Revert "Temporarily ignore i686 bench" r=cuviper a=cuviper

This reverts commit 9da74e7.

The codegen issue was fixed by updates to LLVM 14, rust-lang/rust#94764.


Co-authored-by: Josh Stone <cuviper@gmail.com>
@SNCPlay42 SNCPlay42 mentioned this pull request May 3, 2022
Closed
@cuviper cuviper mentioned this pull request Sep 16, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
10 participants
@nikic @rust-highfive @rust-timer @bors @nagisa @lcnr @rust-log-analyzer @apiraino @Mark-Simulacrum @rustbot