Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cfg(doc) and cfg(doctest) from doc_auto_cfg, fix not() making badge disappear #98065

Closed
SpriteOvO opened this issue Jun 13, 2022 · 3 comments · Fixed by #98108
Closed

Remove cfg(doc) and cfg(doctest) from doc_auto_cfg, fix not() making badge disappear #98065

SpriteOvO opened this issue Jun 13, 2022 · 3 comments · Fixed by #98108
Assignees
@SpriteOvO
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@SpriteOvO
Copy link
Contributor

Context: #43781 (comment)

CC @GuillaumeGomez
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 13, 2022
@GuillaumeGomez
Copy link
Member

Thanks for opening this issue! Someone from the rustdoc team will try to get back to it whenever possible.

@SpriteOvO
Copy link
Contributor Author

Thanks for opening this issue! Someone from the rustdoc team will try to get back to it whenever possible.

@GuillaumeGomez It doesn't look too difficult. I'm going to try to make a PR for it myself, and I'll update here with or without progress.

@GuillaumeGomez
Copy link
Member

Even better! 😄 I'll assign you to the issue in the meantime then.

@SpriteOvO SpriteOvO mentioned this issue Jun 14, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jun 15, 2022
@GuillaumeGomez
Rollup merge of rust-lang#98108 - SpriteOvO:doc_auto_cfg-feature-rmv-…
bb3d1ad 
…fix, r=notriddle,GuillaumeGomez

Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest"

Fixes rust-lang#98065 Context: rust-lang#43781 (comment)

r? `@GuillaumeGomez`
@bors bors closed this as completed in 392d272 Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpriteOvO SpriteOvO

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest" SpriteOvO/rust
2 participants
@GuillaumeGomez @SpriteOvO