Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest" #98108

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest" #98108

merged 2 commits into from
Jun 16, 2022

Conversation

SpriteOvO
Copy link
Contributor

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2022
@SpriteOvO SpriteOvO force-pushed the doc_auto_cfg-feature-rmv-fix branch 3 times, most recently from e450d7f to 07112a9 Compare June 14, 2022 20:10
@GuillaumeGomez
Copy link
Member

Apart from the little nit in the test, looks good to me, thanks!

Want to take a look as well @notriddle ?

@SpriteOvO SpriteOvO force-pushed the doc_auto_cfg-feature-rmv-fix branch from 07112a9 to 72a5673 Compare June 15, 2022 10:53
notriddle
notriddle requested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@notriddle notriddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Just one little nitpick, then we merge!

src/librustdoc/clean/cfg.rs Outdated Show resolved Hide resolved
@SpriteOvO SpriteOvO force-pushed the doc_auto_cfg-feature-rmv-fix branch from 72a5673 to 713578b Compare June 15, 2022 17:15
@notriddle
Copy link
Contributor

@bors r=notriddle,GuillaumeGomez

@bors
Copy link
Contributor

bors commented Jun 15, 2022

📌 Commit 713578b has been approved by notriddle,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 15, 2022
@GuillaumeGomez
Rollup merge of rust-lang#98108 - SpriteOvO:doc_auto_cfg-feature-rmv-…
bb3d1ad 
…fix, r=notriddle,GuillaumeGomez

Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest"

Fixes rust-lang#98065 Context: rust-lang#43781 (comment)

r? `@GuillaumeGomez`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 15, 2022
Closed
@bors
Copy link
Contributor

bors commented Jun 16, 2022

⌛ Testing commit 713578b with merge 392d272...

@bors
Copy link
Contributor

bors commented Jun 16, 2022

☀️ Test successful - checks-actions
Approved by: notriddle,GuillaumeGomez
Pushing 392d272 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 16, 2022
@bors bors merged commit 392d272 into rust-lang:master Jun 16, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 16, 2022
@SpriteOvO SpriteOvO deleted the doc_auto_cfg-feature-rmv-fix branch June 16, 2022 07:54
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (392d272): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 2.0% 2.0% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.8% -0.8% 1
Improvements 🎉
(secondary)		 -3.2% -4.3% 2
All 😿🎉 (primary) 0.6% 2.0% 2

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.5% 2.9% 2
Improvements 🎉
(primary)		 -3.4% -3.4% 1
Improvements 🎉
(secondary)		 -2.2% -2.2% 1
All 😿🎉 (primary) -3.4% -3.4% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 1, 2022
Closed
@ghost ghost mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@notriddle notriddle notriddle requested changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Remove cfg(doc) and cfg(doctest) from doc_auto_cfg, fix not() making badge disappear
7 participants
@SpriteOvO @GuillaumeGomez @notriddle @bors @rust-timer @rust-highfive @rustbot