-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrations for rustc_expand transcribe.rs #100651
Migrations for rustc_expand transcribe.rs #100651
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, will wait until you're happy to un-draft this to merge.
This comment was marked as resolved.
This comment was marked as resolved.
@bors r+ rollup |
…nd_transcribe, r=davidtwco Migrations for rustc_expand transcribe.rs This PR includes some migrations to the new diagnostics API for the `rustc_expand` module. r? `@davidtwco`
…twco tidy: check fluent files for style Inspired by rust-lang#100651 (comment) There were a lot of line length violations, so I've excepted that lint - I'm not sure if fluent files can be formatted to avoid long lines at all.
…nd_transcribe, r=davidtwco Migrations for rustc_expand transcribe.rs This PR includes some migrations to the new diagnostics API for the `rustc_expand` module. r? ``@davidtwco``
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#97962 (Make must_not_suspend lint see through references when drop tracking is enabled) - rust-lang#99966 (avoid assertion failures in try_to_scalar_int) - rust-lang#100637 (Improving Fuchsia rustc support documentation) - rust-lang#100643 (Point at a type parameter shadowing another type) - rust-lang#100651 (Migrations for rustc_expand transcribe.rs) - rust-lang#100669 (Attribute cleanups) - rust-lang#100670 (Fix documentation of rustc_parse::parser::Parser::parse_stmt_without_recovery) - rust-lang#100674 (Migrate lint reports in typeck::check_unused to LintDiagnostic) - rust-lang#100688 (`ty::Error` does not match other types for region constraints) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
tidy: check fluent files for style Inspired by rust-lang#100651 (comment) There were a lot of line length violations, so I've excepted that lint - I'm not sure if fluent files can be formatted to avoid long lines at all.
This PR includes some migrations to the new diagnostics API for the
rustc_expand
module.r? @davidtwco