avoid assertion failures in try_to_scalar_int #99966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
added
the
S-waiting-on-review
|
r? @lcnr |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 17, 2022
avoid assertion failures in try_to_scalar_int Given that this is called `try_to_scalar_int`, we probably shouldn't `assert_int` here. Similarly `try_to_bits` also doesn't `assert!` that the size is correct. Also add some `track_caller` for debugging, while we are at it. r? `@oli-obk`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 17, 2022
avoid assertion failures in try_to_scalar_int Given that this is called `try_to_scalar_int`, we probably shouldn't `assert_int` here. Similarly `try_to_bits` also doesn't `assert!` that the size is correct. Also add some `track_caller` for debugging, while we are at it. r? ``@oli-obk``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 18, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#97962 (Make must_not_suspend lint see through references when drop tracking is enabled) - rust-lang#99966 (avoid assertion failures in try_to_scalar_int) - rust-lang#100637 (Improving Fuchsia rustc support documentation) - rust-lang#100643 (Point at a type parameter shadowing another type) - rust-lang#100651 (Migrations for rustc_expand transcribe.rs) - rust-lang#100669 (Attribute cleanups) - rust-lang#100670 (Fix documentation of rustc_parse::parser::Parser::parse_stmt_without_recovery) - rust-lang#100674 (Migrate lint reports in typeck::check_unused to LintDiagnostic) - rust-lang#100688 (`ty::Error` does not match other types for region constraints) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this is called
try_to_scalar_int, we probably shouldn'tassert_inthere. Similarlytry_to_bitsalso doesn'tassert!that the size is correct.Also add some
track_callerfor debugging, while we are at it.r? @oli-obk