Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 2145: Type privacy and private-in-public lints #100962

Closed
wants to merge 8 commits into from
Closed

RFC 2145: Type privacy and private-in-public lints #100962

wants to merge 8 commits into from

Conversation

Bryanskiy
Copy link
Contributor

@Bryanskiy Bryanskiy commented Aug 24, 2022 •
edited
Loading

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2022
@Bryanskiy Bryanskiy changed the title Add effective visibility table for Public and Exported Access levels Add effective visibility table for Public and Exported access levels Aug 24, 2022
@petrochenkov
Copy link
Contributor

Blocked on #100147.

@petrochenkov petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
@petrochenkov petrochenkov marked this pull request as ready for review August 27, 2022 13:24
@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

petrochenkov
petrochenkov reviewed Aug 27, 2022
View reviewed changes
compiler/rustc_middle/src/middle/privacy.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/ty/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_feature/src/builtin_attrs.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/middle/effective_visibility.rs Outdated Show resolved Hide resolved
compiler/rustc_privacy/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_privacy/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/middle/effective_visibility.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/access_levels.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryanskiy Bryanskiy force-pushed the effective-vis-table-2 branch 2 times, most recently from 0607327 to e1e14da Compare September 2, 2022 14:06
@petrochenkov petrochenkov removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Sep 2, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@Bryanskiy Bryanskiy changed the title Add effective visibility table for Public and Exported access levels RFC 2145 Sep 12, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov changed the title RFC 2145 RFC 2145: Type privacy and private-in-public lints Sep 12, 2022
@petrochenkov petrochenkov mentioned this pull request Sep 12, 2022
Merged
@bors
Copy link
Contributor

bors commented Sep 18, 2022

☔ The latest upstream changes (presumably #101949) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Sep 24, 2022

☔ The latest upstream changes (presumably #102234) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

JohnCSimon commented Nov 6, 2022 •
edited
Loading

ping from triage:
@Bryanskiy

Can you please address the merge conflicts - and post your status on this PR?

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@Bryanskiy
Copy link
Contributor Author

this PR was supposed to be a draft for intermediate results. Since I haven't used it, I'll close it.

@Bryanskiy Bryanskiy closed this Nov 10, 2022
@Bryanskiy Bryanskiy deleted the effective-vis-table-2 branch May 17, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Bryanskiy @petrochenkov @rustbot @rust-log-analyzer @bors @JohnCSimon @rust-highfive