Rollup of 7 pull requests #101949

matthiaskrgr · 2022-09-17T21:30:52Z

Successful merges:

Initial version of 1.64 release notes #101093 (Initial version of 1.64 release notes)
change AccessLevels representation #101713 (change AccessLevels representation)
Bump Unicode to version 15.0.0, regenerate tables #101821 (Bump Unicode to version 15.0.0, regenerate tables)
Enforce "joined()" and "joined_with_noop()" test #101826 (Enforce "joined()" and "joined_with_noop()" test)
Allow using vendoring when running bootstrap from outside the source root #101835 (Allow using vendoring when running bootstrap from outside the source root)
Revert "Copy stage0 binaries into stage0-sysroot" #101942 (Revert "Copy stage0 binaries into stage0-sysroot")
rustdoc: remove unused CSS .non-exhaustive { margin-bottom } #101943 (rustdoc: remove unused CSS .non-exhaustive { margin-bottom })

Failed merges:

r? @ghost
@rustbot modify labels: rollup

… working directory

This reverts commit 32f8eb2.

This selector was added in 959a13d to target a `<div class="non-exhaustive">`. With 4edcf61, the non-exhaustive indicator was changed to a `<details>`, and a separate selector targetting `details.non-exhaustive` was added for it, but the old selector was never removed.

Co-authored-by: Tyler Mandry <tmandry@gmail.com> Co-authored-by: Josh Triplett <josh@joshtriplett.org>

…-Simulacrum Initial version of 1.64 release notes Needs further expansion on some points, with text that will likely end up in the blog post as well. Also adds the release notes from 1.62.1 and 1.63, which weren't present on the branch.

…nkov change AccessLevels representation Part of RFC (rust-lang#48054). This patch implements effective visibility table with basic methods and change AccessLevels table representation according to it. r? ``@petrochenkov``

Bump Unicode to version 15.0.0, regenerate tables r? `@Mark-Simulacrum`

…oop, r=Mark-Simulacrum Enforce "joined()" and "joined_with_noop()" test Several similar tests come in the form of `joined()` and `joined_with_noop()`. In this test, the `joined()` has two calls to a noop, making it functionally equivalent to `joined_with_noop()`. This doesn't seem intended, and this PR removes those calls and changes the memory size to reflect the change For my education, why do tests with `noop()` calls sometimes have `noop()` contributing to the size, while others do not? E.g. https://github.com/rust-lang/rust/blob/master/src/test/ui/async-await/async-fn-size-moved-locals.rs#L115 and https://github.com/rust-lang/rust/blob/master/src/test/ui/async-await/async-fn-size-moved-locals.rs#L116 have no size difference, whereas https://github.com/rust-lang/rust/blob/master/src/test/ui/async-await/async-fn-size-moved-locals.rs#L113 and https://github.com/rust-lang/rust/blob/master/src/test/ui/async-await/async-fn-size-moved-locals.rs#L114 have a size difference. Thank you!

…acrum Allow using vendoring when running bootstrap from outside the source root Fixes rust-lang#100364.

Revert "Copy stage0 binaries into stage0-sysroot" This reverts PR rust-lang#101711. The PR broke the rustc/bootstrap benchmark on rustc-perf, I believe due to the assumption that the stage0 directory exists. Fixing that by just skipping this logic might be reasonable, but I think there's a larger discussion to be had around the right behavior when we don't have a single bin/ directory (when rustc= and cargo= are specified in config.toml). I think it's potentially reasonable to put those binaries (cargo, rustc, rustfmt?) into the bin directory, but for now just want to get us back to a healthy state. r? `@jyn514` (but would appreciate review from others as this is just a direct revert).

…, r=GuillaumeGomez rustdoc: remove unused CSS `.non-exhaustive { margin-bottom }` This selector was added in 959a13d to target a `<div class="non-exhaustive">`. With 4edcf61, the non-exhaustive indicator was changed to a `<details>`, and a separate selector targetting `details.non-exhaustive` was added for it, but the old selector was never removed.

matthiaskrgr · 2022-09-17T21:31:16Z

@bors r+ rollup=never p=7

bors · 2022-09-17T21:31:18Z

📌 Commit 5ba52ca has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-09-17T22:04:31Z

⌛ Testing commit 5ba52ca with merge 5253b0a...

bors · 2022-09-18T00:45:45Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 5253b0a to master...

rust-timer · 2022-09-18T00:47:54Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#101943	e10233649b5cd0a1cb62f754443e11d538a2b509
#101942	be5b958cb9b64105e5fbb730f3d99bd5f118a50f
#101835	7427f7872edb2008c308aadeb24cd5718530737c
#101826	33f31d3333ab21093997743861d7b08f9cb1ee96
#101821	d6a34205dcc821736ec459e2ee3b006da581692b
#101713	d0df9352555c4c4ffceae937ca5d786256f03e32
#101093	bb7cf68141ec84dfed9b2217c5ad80140e4106a7

previous master: 98ad6a5519

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-09-18T02:03:06Z

Finished benchmarking commit (5253b0a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	3
Regressions ❌ (secondary)	0.8%	[0.2%, 3.5%]	15
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.6%, -1.3%]	6
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.7%	[0.9%, 2.3%]	8
Regressions ❌ (secondary)	2.2%	[2.0%, 2.7%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	1.7%	[0.9%, 2.3%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.8%	[-1.8%, -1.8%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

lqd · 2022-09-18T10:37:16Z

@rust-timer build d0df9352555c4c4ffceae937ca5d786256f03e32

rust-timer · 2022-09-18T10:37:18Z

Queued d0df9352555c4c4ffceae937ca5d786256f03e32 with parent 98ad6a5, future comparison URL.

rust-timer · 2022-09-18T11:44:28Z

Finished benchmarking commit (d0df9352555c4c4ffceae937ca5d786256f03e32): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.2%, 3.4%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.7%, -1.5%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	1.2%	[1.2%, 1.2%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Mark-Simulacrum · 2022-09-20T13:16:26Z

@rust-timer build d6a34205dcc821736ec459e2ee3b006da581692b

rust-timer · 2022-09-20T13:16:28Z

Queued d6a34205dcc821736ec459e2ee3b006da581692b with parent 98ad6a5, future comparison URL.

rust-timer · 2022-09-20T14:30:02Z

Finished benchmarking commit (d6a34205dcc821736ec459e2ee3b006da581692b): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	6.1%	[5.2%, 7.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.5%, -2.3%]	2
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-1.9%, -1.9%]	1

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

Bryanskiy and others added 14 commits September 14, 2022 18:11

change AccessLevels representation

d7b9221

Bump Unicode to version 15.0.0, regenerate tables

ac55092

Remove noop from test that expects no noop

4279bd5

Allow using vendoring when running bootstrap from outside the current…

63b8d9b

… working directory

Revert "fix rust-lang#101691: copy stage0 binaries into stage0-sysroot"

f0c78ee

This reverts commit 32f8eb2.

Release notes update

a924b8a

Co-authored-by: Tyler Mandry <tmandry@gmail.com> Co-authored-by: Josh Triplett <josh@joshtriplett.org>

Rollup merge of rust-lang#101821 - thomcc:unicode-15, r=Manishearth

36b066d

Bump Unicode to version 15.0.0, regenerate tables r? `@Mark-Simulacrum`

Rollup merge of rust-lang#101835 - jyn514:fix-vendoring, r=Mark-Simul…

cda20a7

…acrum Allow using vendoring when running bootstrap from outside the source root Fixes rust-lang#100364.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 17, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2022

bors merged commit 5253b0a into rust-lang:master Sep 18, 2022

rustbot added this to the 1.66.0 milestone Sep 18, 2022

bors mentioned this pull request Sep 18, 2022

RFC 2145: Type privacy and private-in-public lints #100962

Closed

rustbot added the perf-regression Performance regression. label Sep 18, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2022

rustbot removed the perf-regression Performance regression. label Sep 20, 2022

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

matthiaskrgr deleted the rollup-xu5cqnd branch October 9, 2022 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #101949

Rollup of 7 pull requests #101949

matthiaskrgr commented Sep 17, 2022

matthiaskrgr commented Sep 17, 2022

bors commented Sep 17, 2022

bors commented Sep 17, 2022

bors commented Sep 18, 2022

rust-timer commented Sep 18, 2022

rust-timer commented Sep 18, 2022

lqd commented Sep 18, 2022

rust-timer commented Sep 18, 2022

rust-timer commented Sep 18, 2022

Mark-Simulacrum commented Sep 20, 2022

rust-timer commented Sep 20, 2022

rust-timer commented Sep 20, 2022

Rollup of 7 pull requests #101949

Rollup of 7 pull requests #101949

Conversation

matthiaskrgr commented Sep 17, 2022

matthiaskrgr commented Sep 17, 2022

bors commented Sep 17, 2022

bors commented Sep 17, 2022

bors commented Sep 18, 2022

rust-timer commented Sep 18, 2022

rust-timer commented Sep 18, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Footnotes

lqd commented Sep 18, 2022

rust-timer commented Sep 18, 2022

rust-timer commented Sep 18, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Footnotes

Mark-Simulacrum commented Sep 20, 2022

rust-timer commented Sep 20, 2022

rust-timer commented Sep 20, 2022

Overall result: no relevant changes - no action needed

Footnotes