-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use smaller span for suggestions #101055
Merged
Merged
Use smaller span for suggestions #101055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Aug 26, 2022
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 26, 2022
r? @compiler-errors |
📌 Commit 3c74dc05ff5f67c25be51e3d4199f86eb84c79f3 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 26, 2022
☔ The latest upstream changes (presumably #101064) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Aug 27, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2022
Rollup of 11 pull requests Successful merges: - rust-lang#96240 (Stabilize `const_ptr_offset_from`.) - rust-lang#99784 (Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default) - rust-lang#100811 (Fix wrong compiletest filters on Windows) - rust-lang#100924 (Smaller improvements of tidy and the unicode generator) - rust-lang#100953 (Update documentation for `write!` and `writeln!`) - rust-lang#101018 (rustdoc: omit start/end tags for empty item description blocks) - rust-lang#101044 (rustdoc: remove unused CSS for `hidden-by-*-hider`) - rust-lang#101046 (rustdoc: remove incorrect CSS selector `.impl-items table td`) - rust-lang#101057 (Merge implementations of HIR fn_decl and fn_sig.) - rust-lang#101062 (rustdoc: remove empty extern_crates and type="text/javascript" on script) - rust-lang#101063 (Merge duplicated CSS rules) Failed merges: - rust-lang#101055 (Use smaller span for suggestions) r? `@ghost` `@rustbot` modify labels: rollup
TaKO8Ki
force-pushed
the
use-smaller-span
branch
from
August 27, 2022 06:23
3c74dc0
to
b33c3d6
Compare
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 27, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 28, 2022
…er-errors Use smaller span for suggestions
This was referenced Aug 28, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 28, 2022
…iaskrgr Rollup of 13 pull requests Successful merges: - rust-lang#97015 (std::io: migrate ReadBuf to BorrowBuf/BorrowCursor) - rust-lang#98301 (Add GDB/LLDB pretty-printers for NonZero types) - rust-lang#99570 (Box::from(slice): Clarify that contents are copied) - rust-lang#100296 (Add standard C error function aliases to last_os_error) - rust-lang#100520 (Add mention of `BufReader` in `Read::bytes` docs) - rust-lang#100885 (Export Cancel from std::os::fortanix_sgx::usercalls::raw) - rust-lang#100955 (Some papercuts on error::Error) - rust-lang#101002 (Provide structured suggestion for `hashmap[idx] = val`) - rust-lang#101038 (no alignment check during interning) - rust-lang#101055 (Use smaller span for suggestions) - rust-lang#101091 (Extend attrs if local_def_id exists) - rust-lang#101098 (rustc_middle: Remove `Visibility::Invisible`) - rust-lang#101102 (unstable-book-gen: use std::fs::write) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.