Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GDB/LLDB pretty-printers for NonZero types #98301

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Add GDB/LLDB pretty-printers for NonZero types #98301

merged 1 commit into from
Aug 28, 2022

Conversation

artemmukhin
Copy link
Contributor

Add GDB/LLDB pretty-printers for NonZero types.
These pretty-printers were originally implemented for IntelliJ Rust by @Kobzol in intellij-rust/intellij-rust#5270.

Part of #29392.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
@jyn514
Copy link
Member

jyn514 commented Jun 26, 2022

@wesleywiser saw you left a ❤️ reaction - would you be comfortable approving the PR? I haven't touched debuginfo much but my understanding is you're currently leading the debugging WG :)

@jyn514 jyn514 added the A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) label Jun 26, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

This looks okay to me, though I'm not super familiar with the scripts.

@bors
Copy link
Contributor

bors commented Jun 26, 2022

📌 Commit 0bc536e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2022
@matthiaskrgr
Rollup merge of rust-lang#98301 - ortem:pretty-printers-nonzero, r=Ma…
e629404 
…rk-Simulacrum

Add GDB/LLDB pretty-printers for NonZero types

Add GDB/LLDB pretty-printers for `NonZero` types.
These pretty-printers were originally implemented for IntelliJ Rust by `@Kobzol` in intellij-rust/intellij-rust#5270.

Part of rust-lang#29392.
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 26, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r-
failed in a rollup #98544 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2022
@artemmukhin artemmukhin force-pushed the pretty-printers-nonzero branch from 0bc536e to e0b6053 Compare June 29, 2022 13:25
@artemmukhin
Copy link
Contributor Author

@matthiaskrgr Thanks for attaching the link to the logs. I tried fixing the tests and pushed the changes. However, I am not able to run the tests locally at the moment, so I am still not sure if I wrote the tests right. Just wondering, is there any way to run the debuginfo tests for this particular PR to check them before making a big rollup?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@artemmukhin artemmukhin force-pushed the pretty-printers-nonzero branch from e0b6053 to bc6049a Compare June 29, 2022 15:39
@JohnCSimon
Copy link
Member

JohnCSimon commented Jul 24, 2022 •
edited
Loading

ping from triage:
@ortem what is the status of this PR? were you able to find the help you needed?

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@artemmukhin
Copy link
Contributor Author

Sorry for the delay. I just have run the tests locally, and it looks like this PR is ready for review.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2022
@wesleywiser
Copy link
Member

@bors r+

Thanks @ortem!

@bors
Copy link
Contributor

bors commented Aug 23, 2022

📌 Commit bc6049a has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 23, 2022
@JohnTitor
Rollup merge of rust-lang#98301 - ortem:pretty-printers-nonzero, r=we…
88ce108 
…sleywiser

Add GDB/LLDB pretty-printers for NonZero types

Add GDB/LLDB pretty-printers for `NonZero` types.
These pretty-printers were originally implemented for IntelliJ Rust by `@Kobzol` in intellij-rust/intellij-rust#5270.

Part of rust-lang#29392.
@JohnTitor JohnTitor mentioned this pull request Aug 23, 2022
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 24, 2022
@JohnTitor
Rollup merge of rust-lang#98301 - ortem:pretty-printers-nonzero, r=we…
4e34bc3 
…sleywiser

Add GDB/LLDB pretty-printers for NonZero types

Add GDB/LLDB pretty-printers for `NonZero` types.
These pretty-printers were originally implemented for IntelliJ Rust by ``@Kobzol`` in intellij-rust/intellij-rust#5270.

Part of rust-lang#29392.
@JohnTitor JohnTitor mentioned this pull request Aug 24, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r-
failed in #100937
https://github.com/rust-lang-ci/rust/runs/7987325792?check_suite_focus=true#step:25:3235

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2022
@artemmukhin artemmukhin force-pushed the pretty-printers-nonzero branch from bc6049a to d8e7781 Compare August 24, 2022 09:01
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@artemmukhin artemmukhin force-pushed the pretty-printers-nonzero branch from f9b8aef to 8de1712 Compare August 24, 2022 10:07
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Aug 24, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@artemmukhin artemmukhin force-pushed the pretty-printers-nonzero branch 2 times, most recently from f233edc to 2a26987 Compare August 24, 2022 12:03
@artemmukhin
Copy link
Contributor Author

@wesleywiser I managed to run debuginfo tests for the PR on CI, and hopefully, now both GDB and LLDB tests should work. Note, T-infra label was added when I temporarily changed the GitHub workflow, so I guess it should be removed manually now.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
@jyn514 jyn514 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 24, 2022
@jyn514
Copy link
Member

jyn514 commented Aug 24, 2022

@bors r=wesleywiser rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 24, 2022

📌 Commit 2a26987 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#98301 - ortem:pretty-printers-nonzero, r=we…
e5ca6a6 
…sleywiser

Add GDB/LLDB pretty-printers for NonZero types

Add GDB/LLDB pretty-printers for `NonZero` types.
These pretty-printers were originally implemented for IntelliJ Rust by ``@Kobzol`` in intellij-rust/intellij-rust#5270.

Part of rust-lang#29392.
This was referenced Aug 28, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2022
@bors
Auto merge of rust-lang#101115 - matthiaskrgr:rollup-iy14ztr, r=matth…
3fdd578 
…iaskrgr

Rollup of 13 pull requests

Successful merges:

 - rust-lang#97015 (std::io: migrate ReadBuf to BorrowBuf/BorrowCursor)
 - rust-lang#98301 (Add GDB/LLDB pretty-printers for NonZero types)
 - rust-lang#99570 (Box::from(slice): Clarify that contents are copied)
 - rust-lang#100296 (Add standard C error function aliases to last_os_error)
 - rust-lang#100520 (Add mention of `BufReader` in `Read::bytes` docs)
 - rust-lang#100885 (Export Cancel from std::os::fortanix_sgx::usercalls::raw)
 - rust-lang#100955 (Some papercuts on error::Error)
 - rust-lang#101002 (Provide structured suggestion for `hashmap[idx] = val`)
 - rust-lang#101038 (no alignment check during interning)
 - rust-lang#101055 (Use smaller span for suggestions)
 - rust-lang#101091 (Extend attrs if local_def_id exists)
 - rust-lang#101098 (rustc_middle: Remove `Visibility::Invisible`)
 - rust-lang#101102 (unstable-book-gen: use std::fs::write)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 85916c7 into rust-lang:master Aug 28, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
10 participants
@artemmukhin @rust-highfive @jyn514 @Mark-Simulacrum @bors @matthiaskrgr @rust-log-analyzer @JohnCSimon @wesleywiser @rustbot