Code

Rollup of 10 pull requests#101249

Code

Merged

bors merged 190 commits intorust-lang:masterrust-lang/rust:masterfrom matthiaskrgr:rollup-wahnoz8matthiaskrgr/rust:rollup-wahnoz8Copy head branch name to clipboardSep 1, 2022

+10,129-4,856

Commits

Commits on Aug 2, 2022

• Compare where predicates to trait bounds.

  Show description for 171d082
  

  aldhsu

  authored and

  Allen Hsu

  committed
  171d082

• Split unfixable lints.

  

  aldhsu

  authored and

  Allen Hsu

  committed
  b96842d

• Add extra test cases from rust-lang#8771, rust-lang#8757, rust-lang#9076.

  

  aldhsu

  authored and

  Allen Hsu

  committed
  3ddc04f

Commits on Aug 3, 2022

• Don't lint transmute_undefined_repr when the the first field of a repr(C) type is compatible with the other type

  Jarcho

  committed
  b426bd5

Commits on Aug 4, 2022

• Extend if_then_some_else_none to also suggest bool::then_some

  mkrasnitski

  committed
  80f0f28

Commits on Aug 7, 2022

• Allow type erasure using *const/mut int_type in transmute_undefined_repr

  Jarcho

  committed
  99e77d0

Commits on Aug 8, 2022

• Add iter_once and iter_empty lints

  sgued

  committed
  73cd954

• Fix the lint in clippy itself

  sgued

  committed
  332e031

• Move iter_once and iter_empty to methods as a late pass

  Show description for f3f86d8
  sgued

  committed
  f3f86d8

• Improve suggestions

  sgued

  committed
  f30d7c2

• Prevent some false positives

  sgued

  committed
  b247594

• Rename new lints to iter_on_empty_collections and iter_on_single_items

  sgued

  committed
  af4885c

Commits on Aug 9, 2022

• Add new lint [positional_named_format_parameters]

  miam-miam

  committed
  9ffddf5

Commits on Aug 10, 2022

• Do not consider method call receiver as an argument in AST.

  cjgillot

  committed
  cf3f71d

• Fix if_let_mutex not checking Mutexes behind refs

  Show description for 6a73a45
  lukaslueg

  committed
  6a73a45

• Add labels to if_let_mutex

  lukaslueg

  committed
  0428f0d

Commits on Aug 11, 2022

• Simplify rustc_ast::visit::Visitor::visit_poly_trait_ref.

  Show description for eb68895
  nnethercote

  committed
  eb68895

• fix

  tamaroning

  committed
  459821b

• give up when gurad has side effects

  tamaroning

  committed
  45084ee

• Merge commit '2b2190cb5667cdd276a24ef8b9f3692209c54a89' into clippyup

  flip1995

  committed
  dc29cfb

• Rollup merge of rust-lang#100392 - nnethercote:simplify-visitors, r=cjgillot

  Show description for 4d8b6d4
  matthiaskrgr

  authored
  4d8b6d4

Commits on Aug 12, 2022

• Auto merge of rust-lang#100419 - flip1995:clippyup, r=Manishearth

  Show description for 9ac237d
  bors

  committed
  9ac237d

• Adjust lint description for better clarity

  mkrasnitski

  committed
  f7f60b8

• Lint trait duplication in one pass.

  

  Allen Hsu

  committed
  8bae517

• Update clippy for introduction of Node::ExprField

  ehuss

  committed
  3c4aec5

• Auto merge of rust-lang#9289 - mkrasnitski:9094, r=xFrednet

  Show description for 05fc1c7
  bors

  committed
  05fc1c7

• Adjust cfgs

  Mark-Simulacrum

  committed
  1a3192a

• Update Changelog to 1.63

  flip1995

  committed
  35486cb

• Auto merge of rust-lang#9324 - flip1995:changelog, r=xFrednet

  Show description for dfa780e
  bors

  committed
  dfa780e

• Update lint versions for 1.63 release

  flip1995

  committed
  f18cd27

Commits on Aug 13, 2022

• Auto merge of rust-lang#9326 - flip1995:version-update, r=xFrednet

  Show description for 4d5d191
  bors

  committed
  4d5d191

Commits on Aug 14, 2022

• Auto merge of rust-lang#9167 - aldhsu:fix-trait-duplication-false-pos, r=flip1995

  Show description for 84df61c
  bors

  committed
  84df61c

• Auto merge of rust-lang#9187 - sgued:iter-once, r=flip1995

  Show description for 679fa9f
  bors

  committed
  679fa9f

• Implement clippy::manual_empty_string_creations lint

  Guilherme-Vasconcelos

  committed
  80826c3

• Update all tests to comply with clippy::manual_empty_string_creations

  Guilherme-Vasconcelos

  committed
  1bf8841

• Skip unnecessary_to_owned when t != t.to_string()

  Show description for 1a2aaf6
  xphoniex

  committed
  1a2aaf6

Commits on Aug 15, 2022

• Auto merge of rust-lang#96745 - ehuss:even-more-attribute-validation, r=cjgillot

  Show description for 86a0a18
  bors

  committed
  86a0a18

• Auto merge of rust-lang#9329 - xphoniex:fix-rust-lang#9317, r=flip1995

  Show description for 8c9040c
  bors

  committed
  8c9040c

• Fix label not starting with lcase-letter

  Show description for 6de4bdf
  

  lukaslueg

  and

  xFrednet

  committed
  6de4bdf

• Simplify the borrow_deref_ref lint example

  stanislav-tkach

  committed
  7727c30

• Auto merge of rust-lang#9318 - lukaslueg:ifletmutexref, r=xFrednet

  Show description for 0fc95e8
  bors

  committed
  0fc95e8

Commits on Aug 16, 2022

• Auto merge of rust-lang#9328 - stanislav-tkach:borrow_deref_ref-remove-extra-deref-from-example, r=giraffate

  Show description for a427b12
  bors

  committed
  a427b12

• Shrink ast::Attribute.

  nnethercote

  committed
  6e5f90a

• Rename some things related to literals.

  Show description for e92183c
  nnethercote

  committed
  e92183c

• Fix example

  alex-semenyuk

  authored
  9e9b3dd

• Auto merge of rust-lang#9040 - miam-miam100:unused_named_parameter, r=dswij

  Show description for 86ac6e8
  bors

  committed
  86ac6e8

• Auto merge of rust-lang#9340 - alex-semenyuk:box_t, r=dswij

  Show description for 048e4d0
  bors

  committed
  048e4d0

• unwrap_used and expect_used: trigger on uses of their _err variants

  sgued

  committed
  c1e0435

• Fix [non_ascii_literal] in tests

  Serial-ATA

  committed
  bd121ef

• suggest map_or in case_sensitive_file_extension_comparisons

  Show description for bfeaae8
  

  Brian Caswell

  committed
  bfeaae8

• Auto merge of rust-lang#9327 - Serial-ATA:non_ascii_literal_macro, r=Alexendoo

  Show description for f4f5bb4
  bors

  committed
  f4f5bb4

• Use CARGO_TARGET_DIR in compile-test

  Serial-ATA

  committed
  343476d

• Auto merge of rust-lang#9343 - Serial-ATA:compiletest-target-env, r=Manishearth

  Show description for a331766
  bors

  committed
  a331766

• Enhance needless_borrow to consider trait implementations

  smoelius

  committed
  a05cb74

• Fix adjacent code

  smoelius

  committed
  032f112

Commits on Aug 17, 2022

• Auto merge of rust-lang#9341 - bmc-msft:suggest-map_or-instead-of-unwrap_or, r=giraffate

  Show description for 18c6818
  bors

  committed
  18c6818

• Handle CARGO_TARGET_DIR not being set in compile-test

  Jarcho

  committed
  48cb816

• Fix typo in as_undescore docs

  Show description for aadd014
  cherryblossom000

  authored
  aadd014

• Auto merge of rust-lang#9344 - Jarcho:opt_target_dir, r=flip1995

  Show description for 4235b64
  bors

  committed
  4235b64

• Auto merge of rust-lang#9345 - cherryblossom000:patch-1, r=flip1995

  Show description for dc497c8
  bors

  committed
  dc497c8

• Rollup merge of rust-lang#100018 - nnethercote:clean-up-LitKind, r=petrochenkov

  Show description for 37eeed7
  matthiaskrgr

  authored
  37eeed7

• Auto merge of rust-lang#9287 - Jarcho:trans_undefined, r=xFrednet

  Show description for 84fb7e0
  bors

  committed
  84fb7e0

• unwrap_used: Fix error message for unwrap_err when expect_used is allowed

  sgued

  committed
  ab91d5a

• Auto merge of rust-lang#9338 - sgued:9331-unwrap-err-used, r=giraffate

  Show description for 849c1c0
  bors

  committed
  849c1c0

Commits on Aug 18, 2022

• Auto merge of rust-lang#9136 - smoelius:enhance-needless-borrow, r=Jarcho

  Show description for c419d0a
  bors

  committed
  c419d0a

• Dont lint on match pattern-binding

  Show description for e87a5a1
  lukaslueg

  committed
  e87a5a1

• Auto merge of rust-lang#9348 - lukaslueg:issue9347, r=Alexendoo

  Show description for eeaaba3
  bors

  committed
  eeaaba3

Commits on Aug 19, 2022

• Auto merge of rust-lang#9295 - Guilherme-Vasconcelos:manual-empty-string-creation, r=dswij

  Show description for 868dba9
  bors

  committed
  868dba9

• Add [unused_peekable] lint

  Serial-ATA

  committed
  2666c38

• Better handle method/function calls

  Serial-ATA

  committed
  0efafa4

• Move AsUnderscore into Casts lint pass

  Jarcho

  committed
  8ab2f88

• Move BorrowAsPtr into Casts lint pass

  Jarcho

  committed
  21f5954

• Move ByteCount into Methods lint pass

  Jarcho

  committed
  2502898

• Move BytesCountToLen into Methods lint pass

  Jarcho

  committed
  ba6a459

• Move CaseSensitiveFileExtensionComparisons into Methods lint pass

  Jarcho

  committed
  e3b7797

• Move GetFirst into Methods lint pass

  Jarcho

  committed
  a8d80d5

• Move ManualOkOr into Methods lint pass

  Jarcho

  committed
  5bc8813

• Move MapClone into Methods lint pass

  Jarcho

  committed
  4523954

• Move MapErrIgnore into Methods lint pass

  Jarcho

  committed
  2f0ed0a

• Move MutMutexLock into Methods lint pass

  Jarcho

  committed
  508cf6b

• Move OpenOptions into Methods lint pass

  Jarcho

  committed
  0cc01ce

• Move PathBufPushOverwrite into Methods lint group

  Jarcho

  committed
  226f135

• Move range_zip_with_len into Methods lint pass

  Jarcho

  committed
  fd53761

• Move RepeatOnce into Methods lint pass

  Jarcho

  committed
  06d752e

• Move StableSortPrimitive to Methods lint pass

  Jarcho

  committed
  e834855

• Move TransmutingNull into Transmute lint pass

  Jarcho

  committed
  e213b6e

• Move UnitHash into Methods lint pass

  Jarcho

  committed
  bb0584d

• Move UnnecessarySortBy into Methods lint pass

  Jarcho

  committed
  d8d4a13

• Move VecResizeToZero into Methods lint pass

  Jarcho

  committed
  8acc4d2

• Move VerboseFileReads into Methods lint pass

  Jarcho

  committed
  d8808db

• Auto merge of rust-lang#8957 - Jarcho:more_pass_merges, r=flip1995

  Show description for 477c16d
  bors

  committed
  477c16d

• Refactor FormatArgsExpn

  Alexendoo

  committed
  4f049f5

• Rework only_used_in_recursion

  Jarcho

  committed
  d95b675

• Move only_used_in_recursion back into complexity

  Jarcho

  committed
  39f4bee

• Auto merge of rust-lang#9349 - Alexendoo:format-args-expn, r=flip1995

  Show description for 3e594de
  bors

  committed
  3e594de

• Auto merge of rust-lang#8804 - Jarcho:in_recursion, r=Alexendoo

  Show description for 3a54117
  bors

  committed
  3a54117

• Register new lint collapsible_str_replace to methods

  nahuakang

  committed
  a4413f7

• Extend and improve initial test cases for collapsible_str_replace

  nahuakang

  committed
  89698b9

• Handle replace calls with char slices

  nahuakang

  committed
  6e86687

• Handle repeated str::replace calls with single char kind to str

  nahuakang

  committed
  a9bd0bd

• Remove checks on char slice; improve lint suggestion

  nahuakang

  committed
  c989746

• Adjust test cases; run cargo dev bless

  nahuakang

  committed
  fb30b64

• Auto merge of rust-lang#9258 - Serial-ATA:unused-peekable, r=Alexendoo

  Show description for 2091142
  bors

  committed
  2091142

Commits on Aug 20, 2022

• Fix typos

  alex-semenyuk

  committed
  2781ad0

• Simplify lint logic and address code review comments

  nahuakang

  committed
  b070b40

• Auto merge of rust-lang#9355 - alex-semenyuk:fixed_typos, r=giraffate

  Show description for 0dfec01
  bors

  committed
  0dfec01

• Auto merge of rust-lang#9269 - nahuakang:collapsible_str_replace, r=flip1995

  Show description for 5820add
  bors

  committed
  5820add

• Add test for rust-lang#8855

  smoelius

  committed
  6f3d398

• Auto merge of rust-lang#8857 - smoelius:fix-8855, r=flip1995

  Show description for 41309df
  bors

  committed
  41309df

Commits on Aug 21, 2022

• Suggest moving redundant generic args of an assoc fn to its trait

  hkmatsumoto

  committed
  bafa89b

• allow check for match in lint [option_if_let_else]

  Show description for 5d403c0
  

  J-ZhengLi

  authored and

  flip1995

  committed
  5d403c0

• and check for Result

  

  J-ZhengLi

  authored and

  flip1995

  committed
  ffe7125

• Update needless_match.stderr

  tamaroning

  committed
  f7a376e

• Reduce indentation and add comment about lint name

  flip1995

  committed
  1f75845

• Auto merge of rust-lang#8696 - J-ZhengLi:issue8492, r=flip1995

  Show description for 87b3afc
  bors

  committed
  87b3afc

• feat(fix): Do not lint if the target code is inside a loop

  

  kyoto7250

  authored and

  flip1995

  committed
  5048af7

• Reduce code duplication

  Show description for 318ed05
  flip1995

  committed
  318ed05

• Improve error if rustfix coverage test spuriously fails

  flip1995

  committed
  070b035

• Auto merge of rust-lang#8992 - kyoto7250:fix_8753, r=flip1995

  Show description for e19a05c
  bors

  committed
  e19a05c

• Auto merge of rust-lang#9092 - tamaroning:fix-needless-match, r=llogiq

  Show description for cc637ba
  bors

  committed
  cc637ba

• Fix to_string_in_format_args false positive

  smoelius

  committed
  687fcf1

• needed_ref -> needs_ref

  smoelius

  committed
  0bc26c8

Commits on Aug 22, 2022

• Auto merge of rust-lang#9259 - smoelius:fix-9256, r=llogiq

  Show description for 5735a3b
  bors

  committed
  5735a3b

Commits on Aug 23, 2022

• Remove the symbol from ast::LitKind::Err.

  Show description for 06d7119
  nnethercote

  committed
  06d7119

• Rename manual_empty_string_creation and move to pedantic

  Alexendoo

  committed
  2cb5318

• Auto merge of rust-lang#9366 - Alexendoo:manual_string_new, r=xFrednet

  Show description for b33002d
  bors

  committed
  b33002d

Commits on Aug 24, 2022

• Stabilize #![feature(label_break_value)]

  Show description for 345c42a
  jyn514

  committed
  345c42a

• Replace contains_ty(..) with Ty::contains(..)

  Show description for a0afbdf
  

  Michael Wright

  committed
  a0afbdf

• Auto merge of rust-lang#9370 - mikerite:20220824_ty_contains, r=Jarcho

  Show description for 79a439a
  bors

  committed
  79a439a

• Rollup merge of rust-lang#99332 - jyn514:stabilize-label-break-value, r=petrochenkov

  Show description for 2cdc54d
  JohnTitor

  authored
  2cdc54d

Commits on Aug 25, 2022

• uninit_vec: Vec::spare_capacity_mut is stable

  Show description for 61aa4ef
  sk1p

  authored
  61aa4ef

Commits on Aug 26, 2022

• add multi_assignments lint

  roynrishingha

  committed
  fb7dffe

• Auto merge of rust-lang#9379 - royrustdev:multi_assignments, r=llogiq

  Show description for 21f103a
  bors

  committed
  21f103a

• Auto merge of rust-lang#9374 - sk1p:patch-1, r=Jarcho

  Show description for 602bec2
  bors

  committed
  602bec2

• Don't lint needless_return if return has attrs

  Show description for fe93b8d
  lukaslueg

  committed
  fe93b8d

Commits on Aug 27, 2022

• Implemented suspicious_to_owned lint to check if to_owned is called on a Cow.

  Show description for de028e2
  xanathar

  committed
  de028e2

• Auto merge of rust-lang#9381 - lukaslueg:issue9361, r=dswij

  Show description for be8bd60
  bors

  committed
  be8bd60

• remove parenthesis from unnecessary_cast suggestion

  llogiq

  committed
  90fe3be

• Add span_contains_comments util

  dswij

  committed
  51e9113

• Ignore when there is comment

  dswij

  committed
  b07d72b

• Auto merge of rust-lang#8984 - xanathar:pr/suspicious_to_owned, r=llogiq

  Show description for 2d4d8e1
  bors

  committed
  2d4d8e1

Commits on Aug 28, 2022

• pretty printing give proper erro message without panic

  chenyukang

  committed
  9678751

• Use hir::Map to prevent false positives

  hkmatsumoto

  committed
  722d136

• Auto merge of rust-lang#9276 - dswij:9164, r=flip1995

  Show description for 8d9da4d
  bors

  committed
  8d9da4d

• Make CI pass

  hkmatsumoto

  committed
  75ed56f

• Support method calls

  hkmatsumoto

  committed
  1529137

• Don't lint literal None from expansion

  lukaslueg

  committed
  c542f1f

• Merge branch 'master' into rustup

  Jarcho

  committed
  3ad398d

• Bump nightly version -> 2022-08-27

  Jarcho

  committed
  278b092

• Fixes for latest nightly

  Jarcho

  committed
  9790a32

• Auto merge of rust-lang#9389 - lukaslueg:penmacro, r=llogiq

  Show description for 4e31c8c
  bors

  committed
  4e31c8c

• Disable incremental compilation on CI

  Jarcho

  committed
  e550739

Commits on Aug 29, 2022

• Auto merge of rust-lang#9388 - Jarcho:rustup, r=Jarcho

  Show description for 28ec27b
  bors

  committed
  28ec27b

• Auto merge of rust-lang#9385 - rust-lang:unnecessary-cast-remove-parens, r=Alexendoo

  Show description for 58bbb1a
  bors

  committed
  58bbb1a

• Fix missing parens in suboptimal_flops sugg

  Show description for 26a6891
  lukaslueg

  committed
  26a6891

• Fix suspicious_to_owned test when c_char is u8

  Alexendoo

  committed
  c5a8230

• Add lint cast_slice_from_raw_parts

  clubby789

  committed
  30979bf

• Update clippy_lints/src/casts/mod.rs

  Show description for cc9f203
  

  clubby789

  and

  Alexendoo

  authored
  cc9f203

• Auto merge of rust-lang#9247 - clubby789:raw_slice_pointer_cast, r=Alexendoo

  Show description for e9f7ce1
  bors

  committed
  e9f7ce1

• Auto merge of rust-lang#9395 - Alexendoo:suspicious-to-owned-test, r=Manishearth

  Show description for e1ecdb6
  bors

  committed
  e1ecdb6

• Fix more parens for suboptimal_flops suggs

  lukaslueg

  committed
  9ffc5a5

Commits on Aug 30, 2022

• Auto merge of rust-lang#9394 - lukaslueg:issue9391, r=Jarcho

  Show description for 4df6032
  bors

  committed
  4df6032

• add UI test for unpretty

  chenyukang

  committed
  77eb1ae

• Use more into_iter rather than drain(..)

  

  Donough Liu

  authored and

  bogon-right

  committed
  97b1a61

• Fix the order of trait_duplication_in_bounds

  Show description for 19ef04f
  Jarcho

  committed
  19ef04f

• Initial implementation of result_large_err

  lukaslueg

  committed
  66a9705

• Auto merge of rust-lang#9373 - lukaslueg:result_large_err, r=Alexendoo

  Show description for 09e4659
  bors

  committed
  09e4659

Commits on Aug 31, 2022

• Fix uintended diagnostic caused by drain(..)

  

  Donough Liu

  authored and

  bogon-right

  committed
  3f66efd

• Auto merge of rust-lang#9397 - Jarcho:trait_dup_order, r=dswij

  Show description for f51aade
  bors

  committed
  f51aade

• Link “? operator” to relevant chapter in The Book

  Show description for e10ab62
  mgeisler

  committed
  e10ab62

• migrate rustc_query_system to use SessionDiagnostic

  Show description for b8075e4
  evopen

  committed
  b8075e4

• link related issue to FIXME

  Show description for d7e07c0
  

  evopen

  and

  davidtwco

  committed
  d7e07c0

• use derive proc macro to impl SessionDiagnostic

  Show description for ac638c1
  evopen

  committed
  ac638c1

• delete leftover comment

  evopen

  committed
  166aef9

• SessionDiagnostic for QueryOverflow error

  evopen

  committed
  7ce59eb

• Avoid needless buffer zeroing in std::sys::windows::fs

  thomcc

  committed
  14dd33b

• lint: avoid linting diag functions with diag lints

  Show description for 11fc785
  davidtwco

  committed
  11fc785

• Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

  Jarcho

  committed
  9a67767

• Fix a typo on wasm64-unknown-unknown doc

  JohnTitor

  authored
  cacc7bf

• Use CountIsStart in clippy

  Jarcho

  committed
  7ed1333

• Rollup merge of rust-lang#100787 - chenyukang:fix-100770-pretty-crash, r=petrochenkov

  Show description for 6438f4a
  matthiaskrgr

  authored
  6438f4a

• Rollup merge of rust-lang#100838 - hkmatsumoto:move-gen-args-to-trait-when-appropriate, r=davidtwco

  Show description for 2af2cda
  matthiaskrgr

  authored
  2af2cda

• Rollup merge of rust-lang#100844 - evopen:migrate-diag, r=davidtwco

  Show description for 22c5c83
  matthiaskrgr

  authored
  22c5c83

• Rollup merge of rust-lang#101140 - Jarcho:clippyup, r=Jarcho

  Show description for ba0011c
  matthiaskrgr

  authored
  ba0011c

• Rollup merge of rust-lang#101161 - ldm0:ldm_fix_diagnostic, r=cjgillot

  Show description for f378155
  matthiaskrgr

  authored
  f378155

• Rollup merge of rust-lang#101165 - ldm0:drain_to_iter, r=cjgillot

  Show description for e535671
  matthiaskrgr

  authored
  e535671

• Rollup merge of rust-lang#101229 - mgeisler:link-try-operator, r=thomcc

  Show description for c30c42e
  matthiaskrgr

  authored
  c30c42e

• Rollup merge of rust-lang#101230 - davidtwco:translation-internal-lint-no-self-lint, r=fee1-dead

  Show description for 0620f6e
  matthiaskrgr

  authored
  0620f6e

• Rollup merge of rust-lang#101236 - thomcc:winfs-nozero, r=ChrisDenton

  Show description for 3da66f0
  matthiaskrgr

  authored
  3da66f0

• Rollup merge of rust-lang#101240 - JohnTitor:JohnTitor-patch-1, r=ehuss

  Show description for 14d216d
  matthiaskrgr

  authored
  14d216d