-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #101508
Rollup of 8 pull requests #101508
Commits on Aug 7, 2022
-
clippy: make generated code nice to read
Feel free to close if this is too minor.
Configuration menu - View commit details
-
Copy full SHA for 7025502 - Browse repository at this point
Copy the full SHA 7025502View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3fc4db - Browse repository at this point
Copy the full SHA a3fc4dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcab4be - Browse repository at this point
Copy the full SHA bcab4beView commit details
Commits on Aug 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 581a01d - Browse repository at this point
Copy the full SHA 581a01dView commit details
Commits on Aug 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6669ea8 - Browse repository at this point
Copy the full SHA 6669ea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d77775 - Browse repository at this point
Copy the full SHA 7d77775View commit details
Commits on Aug 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dbaf2ce - Browse repository at this point
Copy the full SHA dbaf2ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dd9eef - Browse repository at this point
Copy the full SHA 0dd9eefView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9c180f - Browse repository at this point
Copy the full SHA f9c180fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42486b6 - Browse repository at this point
Copy the full SHA 42486b6View commit details
Commits on Aug 29, 2022
-
Auto merge of rust-lang#13056 - DropDemBits:make-refactors, r=Veykril
internal: Migrate to using format arg captures in `syntax::make`
Configuration menu - View commit details
-
Copy full SHA for f02cd0a - Browse repository at this point
Copy the full SHA f02cd0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66ec636 - Browse repository at this point
Copy the full SHA 66ec636View commit details
Commits on Aug 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5f132e6 - Browse repository at this point
Copy the full SHA 5f132e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ecead2 - Browse repository at this point
Copy the full SHA 7ecead2View commit details -
Auto merge of rust-lang#13145 - ChayimFriedman2:unmerge-match-arm, r=…
…jonas-schievink feat: Add a "Unmerge match arm" assist to split or-patterns inside match expressions Fixes rust-lang#13072. The way I implemented it it leaves the `OrPat` in place even if there is only one pattern now but I don't think something will break because of that, and when more code will be typed we'll parse it again anyway. Removing it (but keeping the child pattern) is hard, I don't know how to do that.
Configuration menu - View commit details
-
Copy full SHA for 989b09d - Browse repository at this point
Copy the full SHA 989b09dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45dac9a - Browse repository at this point
Copy the full SHA 45dac9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 662ab0c - Browse repository at this point
Copy the full SHA 662ab0cView commit details
Commits on Aug 31, 2022
-
Use type information to deduce the correct type for "Replace turbofis…
…h with explicit type", even when it is not exactly the same as the turbofish type I implemented that by checking the expressions' type. This could probably be implemented better by taking the function's return type and substituting the generic parameter with the provided turbofish, but this is more complicated.
Configuration menu - View commit details
-
Copy full SHA for e5e9799 - Browse repository at this point
Copy the full SHA e5e9799View commit details -
Support
?
and.await
in "Replace turbofish with explicit type"Now that we use type information this is easy.
Configuration menu - View commit details
-
Copy full SHA for bcdacfe - Browse repository at this point
Copy the full SHA bcdacfeView commit details -
Auto merge of rust-lang#13151 - ChayimFriedman2:replace-turbofish-oth…
…er-type, r=Veykril Use correct type in "Replace turbofish with type" And support `?` and `.await` expressions. Fixes rust-lang#13148. The assist can still show up even if the turbofish's type is not used at all, e.g.: ```rust fn foo<T>() {} let v = foo::<i32>(); ```
Configuration menu - View commit details
-
Copy full SHA for e0e18cc - Browse repository at this point
Copy the full SHA e0e18ccView commit details -
Drop the expander borrow in all control flow paths
The change in rust-lang/rust-analyzer#13123 actually re-uses the RefMut borrow instead of dropping it so we need to drop it manually where required.
Configuration menu - View commit details
-
Copy full SHA for 5c0e252 - Browse repository at this point
Copy the full SHA 5c0e252View commit details -
Auto merge of rust-lang#13154 - Veykril:ty-mac-expander, r=Veykril
Drop the expander borrow in all control flow paths The change in rust-lang/rust-analyzer#13123 actually re-uses the RefMut borrow instead of dropping it so we need to drop it manually where required. Fixes rust-lang/rust-analyzer#13153
Configuration menu - View commit details
-
Copy full SHA for ef27641 - Browse repository at this point
Copy the full SHA ef27641View commit details -
Auto merge of rust-lang#13149 - lowr:fix/unescape-raw-ident-module-pa…
…th, r=Veykril fix: unescape all occurrences of module name in module resolution Fixes rust-lang#13141
Configuration menu - View commit details
-
Copy full SHA for b613896 - Browse repository at this point
Copy the full SHA b613896View commit details -
Auto merge of rust-lang#12793 - lowr:fix/12739, r=Veykril
fix: sort and deduplicate auto traits in trait object types Fixes rust-lang#12739 Chalk solver doesn't sort and deduplicate auto traits in trait object types, so we need to handle them ourselves in the lowering phase, just like [`rustc`](https://github.com/rust-lang/rust/blob/880416180b0a9ee1141c07d4d17667edb77daebd/compiler/rustc_typeck/src/astconv/mod.rs#L1487-L1488) and [`chalk-integration`](https://github.com/rust-lang/chalk/blob/master/chalk-integration/src/lowering.rs#L575) do. Quoting from [the Chalk book](https://rust-lang.github.io/chalk/book/types/rust_types.html#dyn-types): > Note that -- for this purpose -- ordering of bounds is significant. That means that if you create a `dyn Foo + Send` and a `dyn Send + Foo`, chalk would consider them distinct types. The assumption is that bounds are ordered in some canonical fashion somewhere else. Also, trait object types with more than one non-auto traits were previously allowed, but are now disallowed with this patch.
Configuration menu - View commit details
-
Copy full SHA for 56d8886 - Browse repository at this point
Copy the full SHA 56d8886View commit details -
Auto merge of rust-lang#12963 - DesmondWillowbrook:clippy-matches-sou…
…rcegen, r=Veykril clippy: make generated code nice to read Feel free to close if this is too minor. (For context, I _have_ read the clippy policy in `dev/style.md`)
Configuration menu - View commit details
-
Copy full SHA for d9e2207 - Browse repository at this point
Copy the full SHA d9e2207View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e8d96 - Browse repository at this point
Copy the full SHA 43e8d96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4661a60 - Browse repository at this point
Copy the full SHA 4661a60View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5d2463 - Browse repository at this point
Copy the full SHA a5d2463View commit details -
feature: Simplfy branch check logics
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a1b45d - Browse repository at this point
Copy the full SHA 5a1b45dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7464b6d - Browse repository at this point
Copy the full SHA 7464b6dView commit details -
Auto merge of rust-lang#13051 - DropDemBits:attrs-and-comments-on-enu…
…m-variant, r=jonas-schievink fix: Only move comments when extracting a struct from an enum variant Motivating example: ```rs #[derive(Debug, thiserror::Error)] enum Error { /// Some explanation for this error #[error("message")] $0Woops { code: u32 } } ``` now becomes ```rs /// Some explanation for this error #[derive(Debug, thiserror::Error)] struct Woops{ code: u32 } #[derive(Debug, thiserror::Error)] enum Error { #[error("message")] Woops(Woops) } ``` (the `thiserror::Error` derive being copied and the struct formatting aren't ideal, though those are issues for another day)
Configuration menu - View commit details
-
Copy full SHA for cf05b7d - Browse repository at this point
Copy the full SHA cf05b7dView commit details -
Auto merge of rust-lang#13005 - pocket7878:convert-two-arm-bool-match…
…-to-matches-macro, r=jonas-schievink feature: Assist to turn match into matches! invocation Resolves rust-lang#12510 This PR adds an assist, which convert 2-arm match that evaluates to a boolean into the equivalent matches! invocation.
Configuration menu - View commit details
-
Copy full SHA for 79a578a - Browse repository at this point
Copy the full SHA 79a578aView commit details -
Auto merge of rust-lang#13120 - Austaras:master, r=jonas-schievink
turn `unwrap_or` into `unwrap_or_else` and vice versa closes rust-lang#12983
Configuration menu - View commit details
-
Copy full SHA for 7f38581 - Browse repository at this point
Copy the full SHA 7f38581View commit details -
This hir expression isn't needed and only existed as it was simpler to deal with at first as it gave us a direct mapping for the ast version of the same construct. This PR removes it, properly handling the statements that are introduced by macro call expressions.
Configuration menu - View commit details
-
Copy full SHA for 192a79c - Browse repository at this point
Copy the full SHA 192a79cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a580a3 - Browse repository at this point
Copy the full SHA 1a580a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee02a47 - Browse repository at this point
Copy the full SHA ee02a47View commit details -
Auto merge of rust-lang#13156 - Veykril:macro-stmts, r=Veykril
Remove hir::Expr::MacroStmts This hir expression isn't needed and only existed as it was simpler to deal with at first as it gave us a direct mapping for the ast version of the same construct. This PR removes it, properly handling the statements that are introduced by macro call expressions.
Configuration menu - View commit details
-
Copy full SHA for ab068f1 - Browse repository at this point
Copy the full SHA ab068f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fa9d5e - Browse repository at this point
Copy the full SHA 1fa9d5eView commit details -
Auto merge of rust-lang#13134 - Veykril:proc-highlight, r=Veykril
Highlight namerefs by syntax until proc-macros have been loaded Usually when loading up a project, once loading is done we start answering highlight requests while proc-macros haven't always been loaded yet, so we start out with showing a lot of unresolved name-refs. After this PR, we'll use syntax based highlighting for those unresolved namerefs until the proc-macros have been loaded.
Configuration menu - View commit details
-
Copy full SHA for 643c3a5 - Browse repository at this point
Copy the full SHA 643c3a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d786a40 - Browse repository at this point
Copy the full SHA d786a40View commit details
Commits on Sep 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2eec4ed - Browse repository at this point
Copy the full SHA 2eec4edView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6fc4a9 - Browse repository at this point
Copy the full SHA d6fc4a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e66a5a - Browse repository at this point
Copy the full SHA 1e66a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8110119 - Browse repository at this point
Copy the full SHA 8110119View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6b7f45 - Browse repository at this point
Copy the full SHA c6b7f45View commit details -
Auto merge of rust-lang#13165 - Veykril:breakables, r=Veykril
Properly handle break resolution inside non-breakable expressions We now diagnose invalid `continue` expressions and properly handle things like `async` blocks which prevent labels from resolving further. Cleaned this up since `label_break_value` is on the way to stabilization in rust (🎉 finally) and we weren't handling breaks for blocks properly yet.
Configuration menu - View commit details
-
Copy full SHA for c4445e4 - Browse repository at this point
Copy the full SHA c4445e4View commit details -
Auto merge of rust-lang#13161 - ChayimFriedman2:pi-is-zero, r=jonas-s…
…chievink fix: Lower float literals with underscores Fixes rust-lang#13155 (the problem was the `PI` is defined with `_f64` suffix). `PI` is still truncated, though, because `f64` cannot represent the value with full precision.
Configuration menu - View commit details
-
Copy full SHA for f23114c - Browse repository at this point
Copy the full SHA f23114cView commit details -
Auto merge of rust-lang#13160 - ChayimFriedman2:parse-parenthesized-t…
…ype-path-with-coloncolon, r=jonas-schievink fix: Parse TypePathFn with preceding `::` e.g. `impl Fn::() -> ()`. Fixes rust-lang#13157. This was the problem, not that the path was not at the end. I could unify the parsing of `::` of TypePathFn with that of generic arg list, but some code relies on the `::` of generic arg list to be inside it.
Configuration menu - View commit details
-
Copy full SHA for 93c52e4 - Browse repository at this point
Copy the full SHA 93c52e4View commit details
Commits on Sep 2, 2022
-
internal: ignore failures when publishing to ovsx
This has been failing for a while https://github.com/rust-lang/rust-analyzer/runs/8147683225?check_suite_focus=true#step:24:19
Configuration menu - View commit details
-
Copy full SHA for 61ad33d - Browse repository at this point
Copy the full SHA 61ad33dView commit details -
Auto merge of rust-lang#13171 - matklad:open-failure, r=lnicola
internal: ignore failures when publishing to ovsx This has been failing for a while https://github.com/rust-lang/rust-analyzer/runs/8147683225?check_suite_focus=true#step:24:19
Configuration menu - View commit details
-
Copy full SHA for 412d614 - Browse repository at this point
Copy the full SHA 412d614View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ae58b9 - Browse repository at this point
Copy the full SHA 8ae58b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffd79c2 - Browse repository at this point
Copy the full SHA ffd79c2View commit details -
Auto merge of rust-lang#13167 - iDawer:exhaustive_patterns, r=Veykril
feat: Implement `feature(exhaustive_patterns)` from unstable Rust Closes rust-lang#12753 Recognize Rust's unstable `#![feature(exhaustive_patterns)]` (RFC 1872). Allow omitting visibly uninhabited variants from `match` expressions when the feature is on. This adjusts match checking to the current implementation of the postponed RFC 1872 in rustc.
Configuration menu - View commit details
-
Copy full SHA for 4f8153e - Browse repository at this point
Copy the full SHA 4f8153eView commit details -
Don't store SyntheticSyntax in the reverse maps in BodySourceMap
They are ZSTs which we can just create on missing access instead.
Configuration menu - View commit details
-
Copy full SHA for fe0a106 - Browse repository at this point
Copy the full SHA fe0a106View commit details -
Auto merge of rust-lang#13173 - Veykril:synthetic, r=Veykril
Don't store SyntheticSyntax in the reverse maps in BodySourceMap They are ZSTs which we can just create on missing access instead.
Configuration menu - View commit details
-
Copy full SHA for 2bb6635 - Browse repository at this point
Copy the full SHA 2bb6635View commit details -
Lift out the module scope into a field in the Resolver
A Resolver *always* has a module scope at the end of its scope stack, instead of encoding this as an invariant we can just lift this scope out into a field, allowing us to skip going through the scope vec indirection entirely.
Configuration menu - View commit details
-
Copy full SHA for 8828049 - Browse repository at this point
Copy the full SHA 8828049View commit details -
Auto merge of rust-lang#13174 - Veykril:resolver, r=Veykril
Lift out the module scope into a field in the Resolver A Resolver *always* has a module scope at the end of its scope stack, instead of encoding this as an invariant we can just lift this scope out into a field, allowing us to skip going through the scope vec indirection entirely.
Configuration menu - View commit details
-
Copy full SHA for f27f98d - Browse repository at this point
Copy the full SHA f27f98dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 894aa0e - Browse repository at this point
Copy the full SHA 894aa0eView commit details -
Auto merge of rust-lang#13175 - Veykril:resolver, r=Veykril
Clarify the state of (extern) preludes for block def maps
Configuration menu - View commit details
-
Copy full SHA for afa374e - Browse repository at this point
Copy the full SHA afa374eView commit details
Commits on Sep 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 020f689 - Browse repository at this point
Copy the full SHA 020f689View commit details -
Auto merge of rust-lang#13183 - Veykril:break-break, r=Veykril
Fix nested break expressions, expecting unknown types
Configuration menu - View commit details
-
Copy full SHA for 8ddb8b7 - Browse repository at this point
Copy the full SHA 8ddb8b7View commit details
Commits on Sep 4, 2022
-
fix: correct broken logic for return complition
It seems that we've accidentally deleted the tests here couple of years ago, and then fairly recently made a typo during refactor as well. Reinstall tests, with coverage marks this time :-)
Configuration menu - View commit details
-
Copy full SHA for d7ef3f5 - Browse repository at this point
Copy the full SHA d7ef3f5View commit details -
Auto merge of rust-lang#13187 - matklad:return, r=Veykril
fix: correct broken logic for return complition It seems that we've accidentally deleted the tests here couple of years ago, and then fairly recently made a typo during refactor as well. Reinstall tests, with coverage marks this time :-)
Configuration menu - View commit details
-
Copy full SHA for 67920f7 - Browse repository at this point
Copy the full SHA 67920f7View commit details
Commits on Sep 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fdf56cf - Browse repository at this point
Copy the full SHA fdf56cfView commit details
Commits on Sep 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 774e712 - Browse repository at this point
Copy the full SHA 774e712View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f45dc1 - Browse repository at this point
Copy the full SHA 3f45dc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c4fb01 - Browse repository at this point
Copy the full SHA 9c4fb01View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad275f5 - Browse repository at this point
Copy the full SHA ad275f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4282802 - Browse repository at this point
Copy the full SHA 4282802View commit details -
rustdoc: remove outdated CSS
.sub-variant > div > .item-info
This CSS still matches sometimes, as you can see in <https://doc.rust-lang.org/1.63.0/std/collections/enum.TryReserveErrorKind.html#variant.AllocError.fields>, but since nothing else is setting `margin-top`, putting it back to `initial` does nothing. This selector was added in 2fd378b (but it was called `.stability` instead of `.item-info` at the time), probably as an override for the selector immediately above it that sets a negative margin. That negative margin was removed in 593d6d1.
Configuration menu - View commit details
-
Copy full SHA for e1f5d4f - Browse repository at this point
Copy the full SHA e1f5d4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d058800 - Browse repository at this point
Copy the full SHA d058800View commit details -
Rollup merge of rust-lang#101451 - cjgillot:test-100521, r=TaKO8Ki
Add incremental test for changing struct name in assoc type. The ICE appears on beta and is fixed on nightly. Fixes rust-lang#100521
Configuration menu - View commit details
-
Copy full SHA for 631aed8 - Browse repository at this point
Copy the full SHA 631aed8View commit details -
Rollup merge of rust-lang#101468 - spastorino:fix-ice-rpit-hrtb-witho…
…ut-dyn, r=cjgillot fix RPIT ICE for implicit HRTB when missing dyn Closes rust-lang#101297 r? `@cjgillot` cc `@nikomatsakis`
Configuration menu - View commit details
-
Copy full SHA for a12e29a - Browse repository at this point
Copy the full SHA a12e29aView commit details -
Rollup merge of rust-lang#101481 - ChrisDenton:uwp-fix, r=thomcc
Fix compile errors for uwp-windows-msvc targets Fixes rust-lang#101480
Configuration menu - View commit details
-
Copy full SHA for 923dae5 - Browse repository at this point
Copy the full SHA 923dae5View commit details -
Rollup merge of rust-lang#101484 - oli-obk:no_zst, r=eddyb
Remove dead broken code from const zst handling in backends cc `@RalfJung` found by `@eddyb` in rust-lang#98957 (comment)
Configuration menu - View commit details
-
Copy full SHA for 1d49dce - Browse repository at this point
Copy the full SHA 1d49dceView commit details -
Rollup merge of rust-lang#101486 - asquared31415:invalid_repr_list, r…
…=estebank Add list of recognized repr attributes to the unrecognized repr error
Configuration menu - View commit details
-
Copy full SHA for f68d05c - Browse repository at this point
Copy the full SHA f68d05cView commit details -
Rollup merge of rust-lang#101488 - notriddle:notriddle/results-table,…
Configuration menu - View commit details
-
Copy full SHA for cf41b38 - Browse repository at this point
Copy the full SHA cf41b38View commit details -
Rollup merge of rust-lang#101491 - notriddle:notriddle/sub-variant-di…
…v-item-info, r=GuillaumeGomez rustdoc: remove outdated CSS `.sub-variant > div > .item-info` This CSS still matches sometimes, as you can see in <https://doc.rust-lang.org/1.63.0/std/collections/enum.TryReserveErrorKind.html#variant.AllocError.fields>, but since nothing else is setting `margin-top`, putting it back to `initial` does nothing. This selector was added here, but it was called `.stability` instead of `.item-info` at the time, probably as an override for the selector immediately above it that sets a negative margin: https://github.com/rust-lang/rust/blob/2fd378b82b14f2746462018e8510e15a079818a0/src/librustdoc/html/static/rustdoc.css#L514-L522 That negative margin was removed in 593d6d1.
Configuration menu - View commit details
-
Copy full SHA for 1bc6110 - Browse repository at this point
Copy the full SHA 1bc6110View commit details -
Rollup merge of rust-lang#101497 - lnicola:rust-analyzer-2022-09-06, …
…r=lnicola ⬆️ rust-analyzer r? `@ghost`
Configuration menu - View commit details
-
Copy full SHA for 6903a84 - Browse repository at this point
Copy the full SHA 6903a84View commit details