Improve Attribute doc methods #101752
Merged
Improve Attribute doc methods #101752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
sweet, @bors r+ rollup |
bors
added
S-waiting-on-bors
| @@ -233,14 +233,20 @@ impl AttrItem { | |||
|
|
|||
| impl Attribute { | |||
| /// Returns `true` if it is a sugared doc comment (`///` or `//!` for example). | |||
| /// So `#[doc = "doc"]` will return `false`. | |||
| /// So `#[doc = "doc"]` (which is a doc comment) and `#[doc(...)]` (which is not | |||
There was a problem hiding this comment.
#[doc = "doc"] is not a doc comment, and not a comment at all, it's a doc attribute.
I'm not sure why this causes confusion, the function name tells exactly what it does.
There was a problem hiding this comment.
Because /// is a doc comment and syntactic sugar over #[doc = "..."], so the confusion is still quite strong.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#101266 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Final) - rust-lang#101737 (rustdoc: remove no-op CSS `.search-results .result-name > span`) - rust-lang#101752 (Improve Attribute doc methods) - rust-lang#101754 (Fix doc of log function) - rust-lang#101759 (:arrow_up: rust-analyzer) - rust-lang#101765 (Add documentation for TyCtxt::visibility) - rust-lang#101770 (Rustdoc-Json: Don't loose subitems of foreign traits.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lqd