⬆️ rust-analyzer #101759
Merged
⬆️ rust-analyzer #101759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om macro on hover Macro expansion erases whitespace information, and so we end with invalid Rust code.
This creates double newline.
Remove type alias definition on inline Fix rust-lang#13079
Suggest struct when completing enum closes rust-lang#13107
…onst-macro, r=Veykril fix: Insert whitespaces into static & const bodies if they are expanded from macro on hover Partially fixes rust-lang#13143. To resolve the other part we need to expand macros in unevaluated static & const bodies, and I'm not sure we want to. If for example it includes a call to `assert!()`, expanding it will lead to worse hover.
fix: sort all bounds on trait object types Fixes rust-lang#13181 rust-lang#12793 allowed different ordering of trait bounds in trait object types but failed to account for the ordering of projection bounds. I opted for sorting all the bounds at once rather than splitting them into `SmallVec`s so it's easier to do the same thing for other bounds when we have them.
Use proc-macro-srv from sysroot in rust-project.json workspaces This was discussed [on zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/.60sysroot.60.20vs.20.60sysroot_src.60.20for.20.60rust-project.2Ejson.60.3F/near/293023920), basically in `rust-project.json` workspaces RA doesn't respect the `sysroot` setting when picking which `proc-macro-srv` to launch, and this causes abi mismatches in practice. This is the simple fix that `@Veykril` suggested, and I've verified that it works on Fuchsia by inspecting the cmdline with `pgrep rust-analyzer | xargs ps -fp` to check that it's using the `proc-macro-srv` from our prebuilts which matches the `sysroot` specified in our `rust-project.json`. Can this be merged as is, or do we need to add tests that exercise this?
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
…nas-schievink feat: make clicking a closing brace inlay hint go to the opening brace
fix: add semicolon completion to mod fixes rust-lang#13196 `@Veykril` The tests are passing. I added one specifically for this case.
…, r=lnicola Build release artifact against older Glibc When GitHub [deprecated Ubuntu 18.04](https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/) runners, rust-analyzer was forced to bump runners to 20.04 which includes an updated Glib. This renders RA incompatible with the still popular Ubuntu 18.04 and other slightly older distro versions. Until a deprecation plan is announced on RA's side, I propose binaries shall be built against older glibc to maintain compatibility. This PR changes the Release CI workflow to build the `linux-x64/x86_64-unknown-linux-gnu` release in an Ubuntu 18.04 container. Fixes rust-lang#13081 and rust-lang#13085
|
@bors r+ rollup |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#101266 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Final) - rust-lang#101737 (rustdoc: remove no-op CSS `.search-results .result-name > span`) - rust-lang#101752 (Improve Attribute doc methods) - rust-lang#101754 (Fix doc of log function) - rust-lang#101759 (:arrow_up: rust-analyzer) - rust-lang#101765 (Add documentation for TyCtxt::visibility) - rust-lang#101770 (Rustdoc-Json: Don't loose subitems of foreign traits.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost