rustdoc: clean up #toggle-all-docs
#101944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-highfive
added
the
S-waiting-on-review
notriddle
force-pushed
the
notriddle/toggle-all-docs
branch
from
8d05e40 to
a7041e0
Compare
|
I think there was a reason why we kept a link here. Better check with @jsha first. If not, then it's a great cleanup! :) |
|
I've uploaded a preview to https://notriddle.com/notriddle-rustdoc-test/button-toggle-all-docs/index.html |
|
☔ The latest upstream changes (presumably #102809) made this pull request unmergeable. Please resolve the merge conflicts. |
notriddle
force-pushed
the
notriddle/toggle-all-docs
branch
from
3244967 to
0863f6c
Compare
This change converts the element from an `<a>` link to a button. It's pretty much directly trading slightly more CSS for slightly less HTML, and it's also semantically correct (so you don't get a broken "bookmark" option when you right click on it). While doing this, I also got rid of the unnecessary `class="inner"` attribute on the inner span. There was a style targeting `.collapse-toggle > .inner`, but no CSS ever targeted the `#toggle-all-docs > .inner`.
notriddle
force-pushed
the
notriddle/toggle-all-docs
branch
from
0863f6c to
bdbc977
Compare
|
You don't want to hear from @jsha first? Like I said, it's a great cleanup, I just wasn't sure if there wasn't a reason for this to be like that. |
|
I didn't have any particular reason to keep this a link; I agree a button is better. |
GuillaumeGomez
approved these changes
Oct 30, 2022
|
Then let's approve it. Thanks @notriddle! @bors r=jsha,GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 30, 2022
…s, r=jsha,GuillaumeGomez rustdoc: clean up `#toggle-all-docs` This change converts the element from an `<a>` link to a button. It's pretty much directly trading slightly more CSS for slightly less HTML, and it's also semantically correct (so you don't get a broken "bookmark" option when you right click on it). While doing this, I also got rid of the unnecessary `class="inner"` attribute on the inner span. There was a style targeting `.collapse-toggle > .inner`, but no CSS ever targeted the `#toggle-all-docs > .inner`. Preview: https://notriddle.com/notriddle-rustdoc-test/button-toggle-all-docs/index.html
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#97971 (Enable varargs support for calling conventions other than C or cdecl ) - rust-lang#101428 (Add mir building test directory) - rust-lang#101944 (rustdoc: clean up `#toggle-all-docs`) - rust-lang#102101 (check lld version to choose correct option to disable multi-threading in tests) - rust-lang#102689 (Add a tier 3 target for the Sony PlayStation 1) - rust-lang#103746 (rustdoc: add support for incoherent impls on structs and traits) - rust-lang#103758 (Add regression test for reexports in search results) - rust-lang#103764 (All verbosity checks in `PrettyPrinter` now go through `PrettyPrinter::should_print_verbose`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts the element from an
<a>link to a button. It's pretty much directly trading slightly more CSS for slightly less HTML, and it's also semantically correct (so you don't get a broken "bookmark" option when you right click on it).While doing this, I also got rid of the unnecessary
class="inner"attribute on the inner span. There was a style targeting.collapse-toggle > .inner, but no CSS ever targeted the#toggle-all-docs > .inner.Preview: https://notriddle.com/notriddle-rustdoc-test/button-toggle-all-docs/index.html