Rollup of 8 pull requests #102809
Merged
Rollup of 8 pull requests #102809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .gitattributes: Mark minified javascript as binary to filter greps - fix very minor punctuation typo - diagnostic structs: derive on enum (rust-lang#1477) - Update running tests with the new flags (rust-lang#1476) - Rename typeck to hir_analysis (rust-lang#1475) - fix typo and make paragraph consistent (rust-lang#1474) - Update about-this-guide.md - Link to the correct page in "about this guide" - Update r-a config suggestions - don't refer to the compile-time interpreter as "Miri" (rust-lang#1471) - UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558 - Update mdbook and its extensions versions - Remove unmaintained action - Update some actions versions - Fix some typos Update motivated in large part by the most recent commit, to fix `git grep`.
This CSS, added in 34bd2b8, overrode CSS that was applied to the `.since` class: https://github.com/rust-lang/rust/blob/34bd2b845b3acd84c5a9bddae3ff8081c19ec5e9/src/librustdoc/html/static/rustdoc.css#L782-L795 The absolute positioning for `.since` was abandoned in favor of always floating it, so this is no longer needed: rust-lang@5de1391#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413L902-L904
This makes the stylesheet more consistent about how it handles link hover.
…piler-errors Allow transmutes between the same types after erasing lifetimes r? ````@compiler-errors```` on the impl fixes rust-lang#101081 See discussion in the issue and at https://rust-lang.zulipchat.com/#narrow/stream/326866-t-types.2Fnominated/topic/.23101081.3A.20Regression.20transmuting.20.60RwLockReadGuard.3CT.3A.20.3FSized.3E.E2.80.A6 I think this may need lang team signoff as its implications may go beyond the jurisdiction of T-types I'll write up a proper summary later
Remove `mir::CastKind::Misc` As discussed in rust-lang#97649 `mir::CastKind::Misc` is not clear, this PR addresses that by creating a new enum variant for every valid cast. r? ````@oli-obk````
Fix MIR inlining of asm_unwind
The MIR inlining currently doesn't handle inline asm's unwind edge correctly.
This code will cause ICE:
```rust
struct D;
impl Drop for D {
fn drop(&mut self) {}
}
#[inline(always)]
fn foo() {
let _d = D;
unsafe { std::arch::asm!("", options(may_unwind)) };
}
pub fn main() {
foo();
}
```
This PR fixes this issue. I also take the opportunity to extract common code into a method.
…d, r=compiler-errors Remove `DefId` from some `SelectionCandidate` variants They are both from `obligation.predicate.def_id()`, which do not need to be on the `SelectionCandidate`. cc ````@lcnr```` ````@compiler-errors````
… r=ehuss Update rustc-dev-guide - .gitattributes: Mark minified javascript as binary to filter greps - fix very minor punctuation typo - diagnostic structs: derive on enum (rust-lang#1477) - Update running tests with the new flags (rust-lang#1476) - Rename typeck to hir_analysis (rust-lang#1475) - fix typo and make paragraph consistent (rust-lang#1474) - Update about-this-guide.md - Link to the correct page in "about this guide" - Update r-a config suggestions - don't refer to the compile-time interpreter as "Miri" (rust-lang#1471) - UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558 - Update mdbook and its extensions versions - Remove unmaintained action - Update some actions versions - Fix some typos Update motivated in large part by the most recent commit, to fix `git grep`.
…est-version, r=notriddle Update browser UI test version It added the possibility to concatenate strings and numbers and updated the `goto` command so it doesn't stand on its own anymore. r? ````@notriddle````
…tion, r=GuillaumeGomez
rustdoc: remove no-op CSS `.rightside { position: initial }`
This CSS, added in 34bd2b8, overrode CSS that was applied to the `.since` class:
https://github.com/rust-lang/rust/blob/34bd2b845b3acd84c5a9bddae3ff8081c19ec5e9/src/librustdoc/html/static/rustdoc.css#L782-L795
The absolute positioning for `.since` was abandoned in favor of always floating it, so this is no longer needed:
rust-lang@5de1391#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413L902-L904
…n-underline, r=GuillaumeGomez rustdoc: add main-heading and example-wrap link CSS to big selector This makes the stylesheet more consistent about how it handles link hover.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=8 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: bba9785dd7 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (c27948d): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
mir::CastKind::Misc#102675 (Removemir::CastKind::Misc)DefIdfrom someSelectionCandidatevariants #102785 (RemoveDefIdfrom someSelectionCandidatevariants).rightside { position: initial }#102797 (rustdoc: remove no-op CSS.rightside { position: initial })Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup