Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove unused CSS td.summary-column #102005

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

notriddle
Copy link
Contributor

It was added in 2a1bad7 to go with this module summary function:

try!(write!(f, "<td class='summary-column'>"));
try!(write!(f, "<span class='summary Stable' \
style='width: {:.4}%; display: inline-block'>&nbsp</span>",
(100 * cnt.stable) as f64/tot as f64));
try!(write!(f, "<span class='summary Unstable' \
style='width: {:.4}%; display: inline-block'>&nbsp</span>",
(100 * cnt.unstable) as f64/tot as f64));
try!(write!(f, "<span class='summary Deprecated' \
style='width: {:.4}%; display: inline-block'>&nbsp</span>",
(100 * cnt.deprecated) as f64/tot as f64));
try!(write!(f, "<span class='summary Unmarked' \
style='width: {:.4}%; display: inline-block'>&nbsp</span>",
(100 * cnt.unmarked) as f64/tot as f64));
try!(write!(f, "</td></tr>"));

The corresponding HTML was removed in 0a46933.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 19, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Collaborator

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 19, 2022

📌 Commit 60c98ce has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 19, 2022
…umn, r=Dylan-DPC

rustdoc: remove unused CSS `td.summary-column`

It was added in 2a1bad7 to go with this module summary function:

https://github.com/rust-lang/rust/blob/2a1bad70dd9bc99d8db54964108b42da8f4e9fbd/src/librustdoc/html/format.rs#L767-L780

The corresponding HTML was removed in 0a46933.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2022
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#101389 (Tone down explanation on RefCell::get_mut)
 - rust-lang#101798 (Make `from_waker`, `waker` and `from_raw` unstably `const`)
 - rust-lang#101881 (Remove an unused struct field `late_bound`)
 - rust-lang#101904 (Add help for invalid inline argument)
 - rust-lang#101966 (Add unit test for identifier Unicode emoji diagnostics)
 - rust-lang#101979 (Update release notes for 1.64)
 - rust-lang#101985 (interpret: expose generate_stacktrace without full InterpCx)
 - rust-lang#102004 (Try to clarify what's new in 1.64.0 ffi types)
 - rust-lang#102005 (rustdoc: remove unused CSS `td.summary-column`)
 - rust-lang#102017 (Add all submodules to the list of directories tidy skips)
 - rust-lang#102019 (Remove backed off PRs from relnotes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 548c3ea into rust-lang:master Sep 20, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 20, 2022
@notriddle notriddle deleted the notriddle/td-summary-column branch September 20, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants