Add all submodules to the list of directories tidy skips #102017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran git config --file .gitmodules --name-only --get-regexp path and added all submodules that were not already in the list to it.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I think this makes sense. I was going to ask "but what about other tidy lints that might make sense", but I think that set maybe only includes e.g. avoidance of adding binaries to the submodules, which isn't that critical to check and we probably don't want tidy enforcing line length and such in any case for submodules. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#101389 (Tone down explanation on RefCell::get_mut) - rust-lang#101798 (Make `from_waker`, `waker` and `from_raw` unstably `const`) - rust-lang#101881 (Remove an unused struct field `late_bound`) - rust-lang#101904 (Add help for invalid inline argument) - rust-lang#101966 (Add unit test for identifier Unicode emoji diagnostics) - rust-lang#101979 (Update release notes for 1.64) - rust-lang#101985 (interpret: expose generate_stacktrace without full InterpCx) - rust-lang#102004 (Try to clarify what's new in 1.64.0 ffi types) - rust-lang#102005 (rustdoc: remove unused CSS `td.summary-column`) - rust-lang#102017 (Add all submodules to the list of directories tidy skips) - rust-lang#102019 (Remove backed off PRs from relnotes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy contains a blacklist of directories that it is not visiting. This list is also used by the
replace-version-placeholdertool added by #100591 , to determine the directories to do its replacement from. Generally, tidy does not check submodules, but this is not done consistently for all submodules. This PR adds the submodules that were previously missing, so that thereplace-version-placeholdertool does not attempt to change content of the books. This was needed becauserustc-dev-guidecontains the placeholder, leading to #102014.Fixes #102014