-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CSS highlight to CSS variables #102663
Migrate CSS highlight to CSS variables #102663
Conversation
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha A change occurred in the Ayu theme. cc @Cldfire |
I don't think the color changes are an improvement:
|
I'll update following your suggestions then to see if it looks better. |
106c8b2
to
a28c216
Compare
I updated the style as you recommended. I tried to pick good colours for literals but don't hesitate if you have better ones. :) |
☔ The latest upstream changes (presumably #102741) made this pull request unmergeable. Please resolve the merge conflicts. |
a28c216
to
d8d37b8
Compare
Fixed merge conflict. |
Opened a zulip thread for this @ https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Syntax.20highlighting.20.23102663 |
In general we should not combine refactorings with nontrivial feature changes. Can you make the refactoring (change to CSS variables) without making the feature change (merging colors)? Then we can discuss the feature change independently. |
It's a bit complicated because |
…ht-without-change, r=notriddle Migrate css highlight without change This is a "previous" version of rust-lang#102663: only migrating to CSS variables, no changes. It's a bit more verbose because rules are not coherent between themes. r? `@notriddle`
…ht-without-change, r=notriddle Migrate css highlight without change This is a "previous" version of rust-lang#102663: only migrating to CSS variables, no changes. It's a bit more verbose because rules are not coherent between themes. r? ``@notriddle``
…ht-without-change, r=notriddle Migrate css highlight without change This is a "previous" version of rust-lang#102663: only migrating to CSS variables, no changes. It's a bit more verbose because rules are not coherent between themes. r? ```@notriddle```
Part of #98460.
There are UI changes: I unified the colors as follows:
.self
in theayu
theme as it was the only theme with it.You can test it here.
cc @jsha
r? @notriddle