Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate css highlight without change #102914

Merged

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 11, 2022

This is a "previous" version of #102663: only migrating to CSS variables, no changes. It's a bit more verbose because rules are not coherent between themes.

Part of #98460.

r? @notriddle

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 11, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2022

A change occurred in the Ayu theme.

cc @Cldfire

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2022
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 13, 2022

📌 Commit bca1005 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 14, 2022
…ht-without-change, r=notriddle

Migrate css highlight without change

This is a "previous" version of rust-lang#102663: only migrating to CSS variables, no changes. It's a bit more verbose because rules are not coherent between themes.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102847 (impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions)
 - rust-lang#102856 (Only test duplicate inherent impl items in a single place)
 - rust-lang#102914 (Migrate css highlight without change)
 - rust-lang#102938 (Move some tests to more reasonable directories)
 - rust-lang#103015 (fix a typo)
 - rust-lang#103018 (More dupe word typos)
 - rust-lang#103025 (rustdoc: remove unused CSS `.search-container > *`)
 - rust-lang#103031 (Suppress irrefutable let patterns lint for prefixes in match guards)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
albertlarsan68 added a commit to albertlarsan68/rust that referenced this pull request Oct 14, 2022
…ht-without-change, r=notriddle

Migrate css highlight without change

This is a "previous" version of rust-lang#102663: only migrating to CSS variables, no changes. It's a bit more verbose because rules are not coherent between themes.

r? ```@notriddle```
albertlarsan68 added a commit to albertlarsan68/rust that referenced this pull request Oct 14, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102847 (impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions)
 - rust-lang#102856 (Only test duplicate inherent impl items in a single place)
 - rust-lang#102914 (Migrate css highlight without change)
 - rust-lang#102938 (Move some tests to more reasonable directories)
 - rust-lang#103015 (fix a typo)
 - rust-lang#103018 (More dupe word typos)
 - rust-lang#103025 (rustdoc: remove unused CSS `.search-container > *`)
 - rust-lang#103031 (Suppress irrefutable let patterns lint for prefixes in match guards)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 20e1268 into rust-lang:master Oct 14, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 14, 2022
@GuillaumeGomez GuillaumeGomez deleted the migrate-css-highlight-without-change branch October 14, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants