Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: add visible focus outline to rustdoc-toggle #103554

Merged
merged 2 commits into from
Oct 26, 2022
Merged

rustdoc: add visible focus outline to rustdoc-toggle #103554

merged 2 commits into from
Oct 26, 2022

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Oct 25, 2022 •
edited
Loading

The change in opacity is inconsistent with most of rustdoc, which uses default browser styles for the focus outline. Unfortunately, just using the default focus outline here won't work, because it gets applied to the summary itself instead of the pseudo-element "real button."

Preview: https://notriddle.com/notriddle-rustdoc-demos/focus-outline/test_dingus/fn.test.html

Screenshots

light

image

dark

image

ayu

image

@notriddle
rustdoc: add visible focus outline to rustdoc-toggle
60b5f6d 
The change in opacity is inconsistent with most of rustdoc, which uses
default browser styles for the focus outline. Unfortunately, just using
the default focus outline here won't work, because it gets applied to
the summary itself instead of the pseudo-element "real button."
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2022
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 25, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@jsha
Copy link
Contributor

jsha commented Oct 26, 2022

FWIW the default focus ring on Chrome / Linux (Ubuntu) is a solid black line rather than a thin dashed line. But I think it's okay to not match focus styles exactly; just doing an outline vs opacity is a big win.

@notriddle @jsha
Update src/librustdoc/html/static/css/rustdoc.css
b857138 
Co-authored-by: Jacob Hoffman-Andrews <github@hoffman-andrews.com>
@jsha
Copy link
Contributor

jsha commented Oct 26, 2022

Thanks! r=me after CI passes.

@notriddle
Copy link
Contributor Author

@bors r=jsha rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2022

📌 Commit b857138 has been approved by jsha

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2022
@bors
Auto merge of rust-lang#103572 - Dylan-DPC:rollup-a8bnxrw, r=Dylan-DPC
0a6b941 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#95710 (Stabilize arbitrary_enum_discriminant, take 2)
 - rust-lang#102706 (Support excluding the generation of the standalone docs)
 - rust-lang#103428 (Removed verbose printing from the `PrettyPrinter` when printing constants)
 - rust-lang#103543 (Update books)
 - rust-lang#103546 (interpret: a bit of cast cleanup)
 - rust-lang#103554 (rustdoc: add visible focus outline to rustdoc-toggle)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomez
Copy link
Member

It'd be nice to add a GUI test to enforce it.

@bors bors merged commit 74a4c67 into rust-lang:master Oct 26, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 26, 2022
@notriddle notriddle deleted the notriddle/summary-focus-visible branch October 26, 2022 18:05
pietroalbini added a commit to ferrocene/sphinx-shared-resources that referenced this pull request Mar 22, 2023
@bors-ferrocene @Veykril
@pietroalbini @DropDemBits @bors
Merge #600
3f42cd2 
600: Pull changes from upstream `master` r=kirtchev-adacore a=pietroalbini

* rust-lang/rust#103605
* rust-lang/rust#103604
  * rust-lang/rust#103598
  * rust-lang/rust#103596
  * rust-lang/rust#103580
  * rust-lang/rust#103579
  * rust-lang/rust#103567
  * rust-lang/rust#103558
  * rust-lang/rust#103549
  * rust-lang/rust#103537
  * rust-lang/rust#103526
  * rust-lang/rust#103432
* rust-lang/rust#103571
* rust-lang/rust#103492
* rust-lang/rust#103572
  * rust-lang/rust#103554
  * rust-lang/rust#103546
  * rust-lang/rust#103543
  * rust-lang/rust#103428
  * rust-lang/rust#102706
  * rust-lang/rust#95710
* rust-lang/rust#103284
* rust-lang/rust#103562
  * rust-lang/rust#103542
  * rust-lang/rust#103536
  * rust-lang/rust#103533
  * rust-lang/rust#103520
  * rust-lang/rust#103444
  * rust-lang/rust#103430
  * rust-lang/rust#103416
  * rust-lang/rust#103287
  * rust-lang/rust#103209
  * rust-lang/rust#102951
* rust-lang/rust#103279
* rust-lang/rust#103158



Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Co-authored-by: Pietro Albini <pietro.albini@ferrous-systems.com>
Co-authored-by: DropDemBits <r3usrlnd@gmail.com>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: Pietro Albini <pietro@pietroalbini.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rustbot @jsha @bors @GuillaumeGomez @rust-highfive