Rollup of 10 pull requests #103562

Dylan-DPC · 2022-10-26T05:59:58Z

Successful merges:

suggest type annotation for local statement initialed by ref expression #102951 (suggest type annotation for local statement initialed by ref expression)
Diagnostic derives: allow specifying multiple alternative suggestions #103209 (Diagnostic derives: allow specifying multiple alternative suggestions)
Use a faster allocation size check in slice::from_raw_parts #103287 (Use a faster allocation size check in slice::from_raw_parts)
Name the impl Trait in region bound suggestions #103416 (Name the impl Trait in region bound suggestions)
Workaround unstable stmt_expr_attributes for method receiver expressions #103430 (Workaround unstable stmt_expr_attributes for method receiver expressions)
Remove extra type error after missing semicolon error #103444 (Remove extra type error after missing semicolon error)
rustc_middle: Rearrange resolver outputs structures slightly #103520 (rustc_middle: Rearrange resolver outputs structures slightly)
Use &self instead of &mut self for cast methods #103533 (Use &self instead of &mut self for cast methods)
Remove rustc_driver::set_sigpipe_handler() #103536 (Remove rustc_driver::set_sigpipe_handler())
Pinning tests for some macro_rules! errors discussed in the lang meeting #103542 (Pinning tests for some macro_rules! errors discussed in the lang meeting)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

…ons.

This allows porting uses of span_suggestions() to diagnostic structs. Doesn't work for multipart_suggestions() because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while multipart_suggestions() creates multiple possible replacements, each with multiple spans.

… error

Its usage was removed in 5e624bf and 093b075, so we do not need to keep it around any longer. According to [preliminary input](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Find.20.60rustc_driver.60.20dependent.20projects.3F/near/304490764), we do not need to worry about any deprecation cycle for this API and can just straight up remove it. Migration instructions for remaining clients -------------------------------------------- Change from ```rust extern crate rustc_driver; fn main() { rustc_driver::set_sigpipe_handler(); // ... ``` to ```rust fn main() { // ... ```

…bank suggest type annotation for local statement initialed by ref expression In a local statement with a type declaration, if a ref expression is used on the right side and not used on the left side, in addition to removing the `&` and `&mut` on the right side, we can add them on the left side alternatively Fixes rust-lang#102892

…vidtwco Diagnostic derives: allow specifying multiple alternative suggestions This allows porting `span_suggestions()` to diagnostic structs. Doesn't work for `multipart_suggestions()` because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while `multipart_suggestions()` creates multiple possible replacements, each with multiple spans.

Use a faster allocation size check in slice::from_raw_parts I've been perusing through the codegen changes that result from turning on the standard library debug assertions. The previous check in here uses saturating arithmetic, which in my experience sometimes makes LLVM just fail to optimize things around the saturating operation. Here is a demo of the codegen difference: https://godbolt.org/z/WMEqrjajW Before: ```asm example::len_check_old: mov rax, rdi mov ecx, 3 mul rcx setno cl test rax, rax setns al and al, cl ret example::len_check_old: mov rax, rdi mov ecx, 8 mul rcx setno cl test rax, rax setns al and al, cl ret ``` After: ```asm example::len_check_new: movabs rax, 3074457345618258603 cmp rdi, rax setb al ret example::len_check_new: shr rdi, 60 sete al ret ``` Running rustc-perf locally, this looks like up to a 4.5% improvement when `debug-assertions-std = true`. Thanks ```@LegionMammal978``` (I think that's you?) for turning my idea into a much cleaner implementation. r? ```@thomcc```

…llot Name the `impl Trait` in region bound suggestions Slightly more descriptive message

…enkov Workaround unstable stmt_expr_attributes for method receiver expressions Fixes rust-lang#103244 cc ``@Mark-Simulacrum`` ``@ehuss``

…-diag, r=davidtwco Remove extra type error after missing semicolon error Fixes rust-lang#103425

rustc_middle: Rearrange resolver outputs structures slightly Addresses rust-lang#98106 (comment). I also haven't seen the motivation for moving `cstore` from its old place, so I moved it back in this PR. r? ```@cjgillot```

Use &self instead of &mut self for cast methods r? ``@oli-obk``

…, r=tmiasko Remove `rustc_driver::set_sigpipe_handler()` Its usage was removed in rust-lang#102587 and rust-lang#103495, so we do not need to keep it around any longer. According to [preliminary input](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Find.20.60rustc_driver.60.20dependent.20projects.3F/near/304490764), we do not need to worry about any deprecation cycle for this explicitly unstable API, and can just straight up remove it. PR that added `set_sigpipe_handler`: rust-lang#49606 Tracking issue for `unix_sigpipe`: rust-lang#97889 Migration instructions for any remaining clients --- Change from ```rust #![feature(rustc_private)] extern crate rustc_driver; fn main() { rustc_driver::set_sigpipe_handler(); // ... ``` to ```rust #![feature(unix_sigpipe)] #[unix_sigpipe = "sig_dfl"] fn main() { // ... ``` ``@rustbot`` labels +T-compiler

…=compiler-errors Pinning tests for some `macro_rules!` errors discussed in the lang meeting r? ``@nikomatsakis`` Mind just stamping these, since they were useful for the meeting discussion today?

Dylan-DPC · 2022-10-26T06:00:14Z

@bors r+ rollup=never p=5

bors · 2022-10-26T06:00:16Z

📌 Commit 703fb66 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-10-26T07:58:33Z

⌛ Testing commit 703fb66 with merge 629a414...

bors · 2022-10-26T11:29:07Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 629a414 to master...

rust-timer · 2022-10-26T11:31:57Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#103542	b324933b5150ef69ddf4e06209b9750001bf9686
#103536	d88cc706f0951baf24942011faa440112d224390
#103533	c7455d0266e45e0f07143c8ce2c9e8513d75ed38
#103520	ba01717bb841f2688c5f98700db703f95fbabb4e
#103444	853bb570c29977bfa041ba0b41deba3effc8828b
#103430	9e0ddf509c2410c3f0a0bc6f951b1d30185a421b
#103416	e68d7bab7109b8de41ded4f17602544f0fef9fec
#103287	1c98f4eb63d8d132f04250406ec6714bfd29eb77
#103209	6c0fad93db5043ee93f7f771460b5e576941b464
#102951	07a58c26d5132c0e247dceb914a03a961a6a379d

previous master: d49e7e7fa1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-10-26T12:50:07Z

Finished benchmarking commit (629a414): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	43
Regressions ❌ (secondary)	0.5%	[0.2%, 1.2%]	25
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	43

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	3.6%	[0.0%, 7.3%]	4
Regressions ❌ (secondary)	1.7%	[1.7%, 1.7%]	1
Improvements ✅ (primary)	-1.9%	[-2.5%, -1.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[-2.5%, 7.3%]	6

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

pnkfelix · 2022-10-26T14:33:26Z

Visiting for weekly perf triage

all of the primary regressions (which seem small) are all in incr-patched scenarios. Most are also check builds, though there is some debug and opt mixed in as well.
hard to tell from the list of rolled up PR's which one(s) would be to blame here
w.r.t. the secondary benchmarks, the main contributor (in terms of the max regression observed) is deeply-nested-multi, which regressed by 0.74--1.2% depending on the scenario.
- (In this case, the 1.2% regression is to a full build, not an incremental one.)
In any case, the sheer number of impacted benchmarks is large enough that this warrants further review.

Not marking as triaged. I'll try to dig into it later. (but right now I'm trying to finish the triage report in time to get it into TWIR.)

pnkfelix · 2022-10-28T02:43:02Z

@rust-timer build 6c0fad93db5043ee93f7f771460b5e576941b464

rust-timer · 2022-10-28T02:43:04Z

Queued 6c0fad93db5043ee93f7f771460b5e576941b464 with parent d49e7e7, future comparison URL.

rust-timer · 2022-10-28T04:07:10Z

Finished benchmarking commit (6c0fad93db5043ee93f7f771460b5e576941b464): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	38
Regressions ❌ (secondary)	0.3%	[0.2%, 0.6%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	38

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[3.5%, 4.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

saethlin and others added 20 commits October 20, 2022 00:30

Use a faster allocation size check in slice::from_raw_parts

cfcb0a2

Workaround unstable stmt_expr_attributes for method receiver expressi…

74d4eef

…ons.

fix rust-lang#103425, remove extra type error after missing semicolon…

f54c336

… error

suggest type annotation for local statement initialed by ref expression

0fca075

rustc_middle: Rearrange resolver outputs structures slightly

919673e

Use &self instead of &mut self for cast methods

5378c82

Name impl trait in region bound suggestion

726bf18

Pinning tests for some macro_rules things discussed in the lang meeting

5064648

Rollup merge of rust-lang#103416 - compiler-errors:rpit-named, r=cjgi…

7858287

…llot Name the `impl Trait` in region bound suggestions Slightly more descriptive message

Rollup merge of rust-lang#103430 - cjgillot:receiver-attrs, r=petroch…

c9a04cd

…enkov Workaround unstable stmt_expr_attributes for method receiver expressions Fixes rust-lang#103244 cc ``@Mark-Simulacrum`` ``@ehuss``

Rollup merge of rust-lang#103444 - chenyukang:yukang/fix-103425-extra…

742741f

…-diag, r=davidtwco Remove extra type error after missing semicolon error Fixes rust-lang#103425

Rollup merge of rust-lang#103533 - jachris:cast-without-mut, r=oli-obk

39e0e2c

Use &self instead of &mut self for cast methods r? ``@oli-obk``

Rollup merge of rust-lang#103542 - scottmcm:invalid-macro-patterns, r…

703fb66

…=compiler-errors Pinning tests for some `macro_rules!` errors discussed in the lang meeting r? ``@nikomatsakis`` Mind just stamping these, since they were useful for the meeting discussion today?

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 26, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2022

bors merged commit 629a414 into rust-lang:master Oct 26, 2022

rustbot added this to the 1.66.0 milestone Oct 26, 2022

rustbot added the perf-regression Performance regression. label Oct 26, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2022

kornelski mentioned this pull request Oct 9, 2023

Handle out of memory errors in io::Read::read_to_end #116570

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #103562

Rollup of 10 pull requests #103562

Dylan-DPC commented Oct 26, 2022

Dylan-DPC commented Oct 26, 2022

bors commented Oct 26, 2022

bors commented Oct 26, 2022

bors commented Oct 26, 2022

rust-timer commented Oct 26, 2022

rust-timer commented Oct 26, 2022

pnkfelix commented Oct 26, 2022

pnkfelix commented Oct 28, 2022

rust-timer commented Oct 28, 2022

rust-timer commented Oct 28, 2022

Rollup of 10 pull requests #103562

Rollup of 10 pull requests #103562

Conversation

Dylan-DPC commented Oct 26, 2022

Dylan-DPC commented Oct 26, 2022

bors commented Oct 26, 2022

bors commented Oct 26, 2022

bors commented Oct 26, 2022

rust-timer commented Oct 26, 2022

rust-timer commented Oct 26, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

pnkfelix commented Oct 26, 2022

pnkfelix commented Oct 28, 2022

rust-timer commented Oct 28, 2022

rust-timer commented Oct 28, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes