Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracking issue for string_extend_from_within #103807

Merged
merged 1 commit into from Nov 2, 2022
Merged

Add tracking issue for string_extend_from_within #103807

merged 1 commit into from Nov 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2022

Tracking issue: #103806

The original PR didn't create a tracking issue.

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 31, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@ghost ghost mentioned this pull request Oct 31, 2022
Open
4 tasks
@ghost
Copy link
Author

ghost commented Nov 1, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 1, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 2, 2022

📌 Commit 3e23d60 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2022
@bors
Auto merge of rust-lang#103888 - Dylan-DPC:rollup-p7gubqj, r=Dylan-DPC
edf0182 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#103275 (Update tinystr)
 - rust-lang#103703 (Gate some parser recovery behind the check)
 - rust-lang#103774 (Format `dyn Trait` better in `type_name` intrinsic)
 - rust-lang#103807 (Add tracking issue for `string_extend_from_within`)
 - rust-lang#103855 (rustdoc: simplify mobile item-table CSS)
 - rust-lang#103862 (Use `ObligationCtxt` in `fully_normalize`)
 - rust-lang#103864 (Reorder `walk_` functions in intravisit.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 68db106 into rust-lang:master Nov 2, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 2, 2022
@ghost ghost deleted the string-extend-from-within-tracking-issue branch November 2, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rustbot @Dylan-DPC @bors @Mark-Simulacrum