Rollup of 7 pull requests #103888
Merged
Rollup of 7 pull requests #103888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly in `expr.rs`
Using flexbox in column direction is needlessly complicated, since no special flex powers are being used here. Just use regular block layout. This should result in no visible changes.
Update tinystr Tinystr has changed a ton since the old version and is much less unsafe, updated some of the dependencies that use it.
…ler-errors Gate some parser recovery behind the check Mainly in `expr.rs`. `may_recover` doesn't do anything useful yet until I implement that on top of rust-lang#103439. r? `@compiler-errors`
…name, r=eholk Format `dyn Trait` better in `type_name` intrinsic Noticed this in rust-lang#103764 (though not related to that PR at all!) ```rust trait Foo { type Bar; } fn main() { println!( "`dyn Fn(i32, i32) -> i32` => `{}`", std::any::type_name::<dyn Fn(i32, i32) -> i32>() ); println!( "`dyn Foo<Bar = i32> + Send + Sync` => `{}`", std::any::type_name::<dyn Foo<Bar = i32> + Send + Sync>() ); } ``` ``` `dyn Fn(i32, i32) -> i32` => `dyn core::ops::function::Fn<(i32, i32)>+Output = i32` `dyn Foo<Bar = i32> + Send + Sync` => `dyn playground::Foo+Bar = i32+core::marker::Sync+core::marker::Send` ``` Just reuse `pretty_print_dyn_existential` which already makes an attempt to make its output stable.
…cking-issue, r=Dylan-DPC Add tracking issue for `string_extend_from_within` Tracking issue: rust-lang#103806 The original PR didn't create a tracking issue.
…ble, r=GuillaumeGomez rustdoc: simplify mobile item-table CSS Using flexbox in column direction is needlessly complicated, since no special flex powers are being used here. Just use regular block layout. This should result in no visible changes.
…lize, r=spastorino Use `ObligationCtxt` in `fully_normalize` Simplifies the implementation a bit
…=fee1-dead Reorder `walk_` functions in intravisit.rs Reorder the `walk_` functions to match the order of the `visit_` methods. This is a follow up to rust-lang#103692. Note that there are some oddballs. I put them where I thought made the most sense: ```diff $ diff \ <(sed -n 's/^.*\<fn visit_\([^(]*\).*$/\1/;T;p' compiler/rustc_hir/src/intravisit.rs) \ <(sed -n 's/^.*\<fn walk_\([^<]*\).*$/\1/;T;p' compiler/rustc_hir/src/intravisit.rs) 1,5d0 < nested_item < nested_trait_item < nested_impl_item < nested_foreign_item < nested_body 9,10d3 < id < name 20c13 < array_length --- > array_len 30a24 > fn_ret_ty 31a26 > fn_kind 41c36 < variant_data --- > struct_def 46c41 < infer --- > inf 54d48 < attribute ``` Also, as some weak evidence that i did things correctly, I get the following before and after the change: ```sh $ sort compiler/rustc_hir/src/intravisit.rs | openssl sha256 SHA256(stdin)= cac13d2545731ef442f318e2b4286490d7ac5494f4ad10c4cf4c5d4f50d21641 ``` r? `@fee1-dead`
rustbot
added
T-bootstrap
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: c0a7612728 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 2, 2022
|
Finished benchmarking commit (edf0182): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
|
Regressions are in secondary benchmarks and look to be noise (recover in the next merge). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
dyn Traitbetter intype_nameintrinsic #103774 (Formatdyn Traitbetter intype_nameintrinsic)string_extend_from_within#103807 (Add tracking issue forstring_extend_from_within)ObligationCtxtinfully_normalize#103862 (UseObligationCtxtinfully_normalize)walk_functions in intravisit.rs #103864 (Reorderwalk_functions in intravisit.rs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup