Rollup of 9 pull requests #104083
Merged
Rollup of 9 pull requests #104083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss-crate functions and methods
…ions & function pointers for consistency with the way we display local definitions (cleaned from HIR, not from rustc_middle).
… where-clause to param declaration site I've overlooked this in rust-lang#103190.
…ds in trait-object types
as well as some FIXMEs
Moved type_array function to rustc_codegen_ssa::BaseTypeMethods trait. This allows using normal alloca function to create arrays as suggested in rust-lang#104022. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Also makes the code dryer.
This hack was removed in 6a5f8b1, but the CSS was left in.
It's been a warning for 5.5 years. Time to make it a hard error. Closes rust-lang#42326.
…-reexport-fixes, r=cjgillot,GuillaumeGomez
rustdoc: various cross-crate reexport fixes
Fixes for various smaller cross-crate reexport issues.
The PR is split into several commits for easier review. Will be squashed after approval.
Most notable changes:
* We finally render late-bound lifetimes in the generic parameter list of cross-crate functions & methods.
Previously, we would display the re-export of `pub fn f<'s>(x: &'s str) {}` as `pub fn f(x: &'s str)`
* We now render unnamed parameters of cross-crate functions and function pointers as underscores
since that's exactly what we do for local definitions, too. Mentioned as a bug in rust-lang#44306.
* From now on, the rendering of cross-crate trait-object types is more correct:
* `for<>` parameter lists (for higher-ranked lifetimes) are now shown
* the return type of `Fn{,Mut,Once}` trait bounds is now displayed
Regarding the last list item, here is a diff for visualization (before vs. after):
```patch
- dyn FnOnce(&'any str) + 'static
+ dyn for<'any> FnOnce(&'any str) -> bool + 'static
```
The redundant `+ 'static` will be removed in a follow-up PR that will hide trait-object lifetime-bounds if they coincide with [their default](https://doc.rust-lang.org/reference/lifetime-elision.html#default-trait-object-lifetimes) (see [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/clean_middle_ty.3A.20I.20need.20to.20add.20a.20parameter/near/307143097)). `FIXME(fmease)`s were added.
``@rustbot`` label A-cross-crate-reexports
r? ``@GuillaumeGomez``
…enkov Make underscore_literal_suffix a hard error. It's been a warning for 5.5 years. Time to make it a hard error. Closes rust-lang#42326. r? ``@pnkfelix``
Add type_array to BaseTypeMethods Moved `type_array` function to `rustc_codegen_ssa::BaseTypeMethods` trait. This allows using normal `alloca` function to create arrays as suggested in rust-lang#104022. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Vec: IntoIterator signature consistency Also makes the code dryer.
…trochenkov Fix typo in `rustc_middle/lint.rs`
…, r=GuillaumeGomez rustdoc: remove unused CSS `#sidebar-filler` This hack was removed in 6a5f8b1, but the CSS was left in.
…lter, r=notriddle Migrate rust logo filter to CSS variables
LLVM 16: Update RISCV data layout The RISCV data layout was changed in llvm/llvm-project@974e2e6. This updates all `riscv64*` targets, though I don't really know what the difference between the `gc` and `imac` ones is. Passes `x test codegen` at LLVM head and with the currently bundled LLVM version. Without this patch, some tests fail with: > error: internal compiler error: compiler/rustc_codegen_llvm/src/context.rs:192:13: data-layout for target `riscv64gc-unknown-none-elf`, `e-m:e-p:64:64-i64:64-i128:128-n64-S128`, differs from LLVM target's `riscv64` default layout, `e-m:e-p:64:64-i64:64-i128:128-n32:64-S128
… r=Mark-Simulacrum rustdoc: Add an example for round that is different from truncate The current examples for [round](https://github.com/rust-lang/rust/blob/master/library/std/src/f64.rs#L75) would have the same results as the example for [truncate](https://github.com/rust-lang/rust/blob/master/library/std/src/f64.rs#L95). This PR adds one more example to `round` that will have a different result from `truncate`.
rustbot
added
S-waiting-on-review
|
@bors r+ p=9 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 7eef946fc0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (9b735a7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_middle/lint.rs#104059 (Fix typo inrustc_middle/lint.rs)#sidebar-filler#104062 (rustdoc: remove unused CSS#sidebar-filler)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup