Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fixes/improvements to mir::visit module #105681

Merged
merged 2 commits into from
Jan 3, 2023
Merged

some fixes/improvements to mir::visit module #105681

merged 2 commits into from
Jan 3, 2023

Conversation

tshepang
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2022
Noratrieb
Noratrieb reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? @Nilstrieb

r=me modulo the review comment

@rustbot rustbot assigned Noratrieb and unassigned eholk Dec 16, 2022
@tshepang @Noratrieb
accept review suggestion
5a7e8f8 
Co-authored-by: nils <48135649+Nilstrieb@users.noreply.github.com>
@Noratrieb
Copy link
Member

@bors r+ rollup

Sorry for forgetting about this

@bors
Copy link
Contributor

bors commented Jan 3, 2023

📌 Commit 5a7e8f8 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2023
@bors
Auto merge of rust-lang#106409 - matthiaskrgr:rollup-b58z1hz, r=matth…
ab10908 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104552 (warn newer available version of the x tool)
 - rust-lang#105681 (some fixes/improvements to mir::visit module)
 - rust-lang#106005 (Test the borrowck behavior of if-let guards)
 - rust-lang#106356 (clean: Remove `ctor_kind` from `VariantStruct`.)
 - rust-lang#106365 (Grammar : Missing "is" in format specifier diagnostic)
 - rust-lang#106388 (rustdoc: remove legacy box-sizing CSS)
 - rust-lang#106392 (`has_overflow` only if value is *not* within limit)
 - rust-lang#106402 (Fix dupe word typos)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da07053 into rust-lang:master Jan 3, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 3, 2023
@tshepang tshepang deleted the doc-mir-visit branch January 4, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rustbot @Noratrieb @bors @eholk