Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite E0158 error-code docs for clarity #105744

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Rewrite E0158 error-code docs for clarity #105744

merged 1 commit into from
Dec 16, 2022

Conversation

Ezrashaw
Copy link
Contributor

Fixes #105585.

The E0158 error-code docs are unclear. It doesn't explain all three different variants of the error and doesn't explain why the error occurs. This PR cleans it up a bit and brings it properly into line with RFC1567.

I'm a first time Rust contributor so I've probably not got it quite right. I also haven't run the whole build process because I assume that my minor docs changes shouldn't break everything.

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2022
@Noratrieb
Copy link
Member

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned Noratrieb Dec 15, 2022
@GuillaumeGomez
Copy link
Member

Please fix the CI error and squash your commits then I'll approve it. Thanks for working on this!

@Ezrashaw
Copy link
Contributor Author

Ezrashaw commented Dec 15, 2022 •
edited
Loading

CI error should be fixed, just waiting for run.
Just to confirm, you want me to squash locally and then force-push (sorry, I'm new to this)?

Done, hopefully should be alright. Thanks for all your help.

@Ezrashaw
Copy link
Contributor Author

@GuillaumeGomez I also have new long-form error docs for E0320 and E0472, should I mark them for you to review? (I haven't PRed them yet)

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez I also have new long-form error docs for E0320 and E0472, should I mark them for you to review? (I haven't PRed them yet)

Sure. I'm currently in holiday so if the current pace is fine for you, feel free to assign them to me.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 16, 2022

📌 Commit fded03e has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2022
@bors
Auto merge of rust-lang#105775 - matthiaskrgr:rollup-2o8qn7e, r=matth…
63b3bac 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105725 (Allow `impl ~const Trait` opaque types)
 - rust-lang#105744 (Rewrite `E0158` error-code docs for clarity)
 - rust-lang#105747 (Fix ICE calling method on auto trait)
 - rust-lang#105748 (doc: Fix a few small issues)
 - rust-lang#105756 (rustdoc: simplify CSS for codeblock tooltips)
 - rust-lang#105757 (rustdoc: remove unused CSS `.sub-settings`)
 - rust-lang#105764 (rustdoc: name the source page sidebar-toggle `#src-sidebar-toggle`)
 - rust-lang#105774 (Remove unused stderr files)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3b9aea9 into rust-lang:master Dec 16, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 16, 2022
@Ezrashaw Ezrashaw deleted the e0158-clarity branch December 18, 2022 03:25
@Ezrashaw Ezrashaw restored the e0158-clarity branch December 18, 2022 03:25
@Ezrashaw Ezrashaw deleted the e0158-clarity branch December 18, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

E0158 explanation refers to statics, when it should be talking about associated consts
5 participants
@Ezrashaw @rustbot @Noratrieb @GuillaumeGomez @bors