Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest rewriting a malformed hex literal if we expect a float #105852

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Suggest rewriting a malformed hex literal if we expect a float #105852

merged 1 commit into from
Dec 28, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #104706

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2022
@bors
Copy link
Contributor

bors commented Dec 22, 2022

☔ The latest upstream changes (presumably #106034) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor

r=me after rebase

@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2022
@compiler-errors
Copy link
Member Author

@bors r=cjgillot rollup

@bors
Copy link
Contributor

bors commented Dec 27, 2022

📌 Commit 3cf22de has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 27, 2022
@compiler-errors compiler-errors mentioned this pull request Dec 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2022
@bors
Auto merge of rust-lang#106193 - compiler-errors:rollup-0l54wka, r=co…
739d68a 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103718 (More inference-friendly API for lazy)
 - rust-lang#105765 (Detect likely `.` -> `..` typo in method calls)
 - rust-lang#105852 (Suggest rewriting a malformed hex literal if we expect a float)
 - rust-lang#105965 (Provide local extern function arg names)
 - rust-lang#106064 (Partially fix `explicit_outlives_requirements` lint in macros)
 - rust-lang#106179 (Fix a formatting error in Iterator::for_each docs)
 - rust-lang#106181 (Fix doc comment parsing description in book)
 - rust-lang#106187 (Update the documentation of `Vec` to use `extend(array)` instead of `extend(array.iter().copied())`)
 - rust-lang#106189 (Fix UnsafeCell Documentation Spelling Error)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 996fb66 into rust-lang:master Dec 28, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 28, 2022
@compiler-errors compiler-errors deleted the hex-float-lit branch August 11, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Account for incorrect attempts to declare "hexadecimal float literals" in E0308
4 participants
@compiler-errors @rustbot @bors @cjgillot