-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #105918
Rollup of 7 pull requests #105918
Conversation
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Co-authored-by: <@ch-iv>
…r=dtolnay Realistic `Path::as_mut_os_str` doctest With "Implement DerefMut for PathBuf" (rust-lang#105018) now merged, it's possible to exercise `Path::as_mut_os_str` (rust-lang#105002) without going through `into_boxed_path`.
…, r=jruderman,GuillaumeGomez Add long error docs for `E0460` and `E0457` Final docs for errors in rust-lang#61137 that have UI tests, my next PRs will also add these tests. r? ``@GuillaumeGomez``
Test that we don't add a new kind of breaking change with TAITs r? ``@lcnr``
…=eholk docs: improve pin docs Override rust-lang#104195 with a full cleanup of the git history, now it should be ready to be merged. r? ``@eholk`` ``@rustbot`` label +A-async-await
Update books ## rust-lang/nomicon 1 commits in ae406aa5287a9e025abb72343aaceec98458c117..dd37e21ccee43918ed18a71581bb2af537ffe4fc 2022-12-09 22:04:38 UTC to 2022-12-09 22:04:38 UTC - Update lifetime-mismatch.md (rust-lang/nomicon#387) ## rust-lang/rust-by-example 3 commits in a9869b4a3c4cac3bc6099b41f088679e268400b8..995df09b65c582eb6290ab7ea5d9485983eb4c37 2022-12-08 23:29:31 UTC to 2022-12-08 23:28:31 UTC - Add documentation for let-else. (rust-lang/rust-by-example#1640) - Added missing space in comment (rust-lang/rust-by-example#1644) - Clean up Chapter 1 (Hello World) (rust-lang/rust-by-example#1650) ## rust-lang/rustc-dev-guide 8 commits in e269950..8b42eb5 2022-12-17 22:41:27 UTC to 2022-12-07 05:42:57 UTC - Add -Ztrack-diagnostics information (rust-lang/rustc-dev-guide#1506) - Add documentation for LLVM KCFI support (rust-lang/rustc-dev-guide#1529) - Replace references to NoLandingPads in MIR pass documents (rust-lang/rustc-dev-guide#1531) - share same link (rust-lang/rustc-dev-guide#1530) - chore: Update `actions/github-script` to v6 (rust-lang/rustc-dev-guide#1521) - fix: Fix broken links (rust-lang/rustc-dev-guide#1522) - Remove TyS (rust-lang/rustc-dev-guide#1526) - Fix small inaccuracy in monomorph page (rust-lang/rustc-dev-guide#1525)
… r=GuillaumeGomez rustdoc: remove width-limiter from source pages, stop overriding CSS
…rm-resumety, r=tmandry Revert "Replace usage of `ResumeTy` in async lowering with `Context`" Reverts rust-lang#105250 Fixes: rust-lang#105501 Following instructions from [forge](https://forge.rust-lang.org/compiler/reviews.html#reverts). This change introduced a breaking change that is not actionable nor relevant, and is blocking updates to our toolchain. Along with other comments on the CL marking issues that are fixed by reverts, reverting is best until these issues can be resolved cc. `@Swatinem`
@bors r+ rollup=never p=7 |
Should we lower the priority on this rollup, there's a PR fixing a P-critical in the queue, #105905, or does this one also fix another such high priority issue ? |
If we want to get the revert merged today we should raise its priority instead of lowering the priority of other PRs. The only PR in the rollup that could matter whether we land it now or later is #105501 which is also a regression but that seems to be hit significantly less than the P-critical revert. I think we should raise the priority of that PR to 10. |
I also agree that the revert PR should be higher prio, it's not about lowering other PRs but this rollup in particular, which has p=7 and IIUC the forge documents such >5 prio to be for P-critical issues, hence my question. |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: 696563efc5 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (c43bc13): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Just one miniscule regression in a @rustbot label: +perf-regression-triaged |
Successful merges:
Path::as_mut_os_str
doctest #105801 (RealisticPath::as_mut_os_str
doctest)E0460
andE0457
#105860 (Add long error docs forE0460
andE0457
)ResumeTy
in async lowering withContext
" #105915 (Revert "Replace usage ofResumeTy
in async lowering withContext
")Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup