Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misleading "add dyn keyword before derive macro" suggestion #106072

Merged
merged 1 commit into from
Jan 15, 2023
Merged

fix: misleading "add dyn keyword before derive macro" suggestion #106072

merged 1 commit into from
Jan 15, 2023

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Dec 23, 2022

Fixes #106071

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2022
@compiler-errors
Copy link
Member

This needs a UI test that demonstrates the fix: https://rustc-dev-guide.rust-lang.org/tests/ui.html
Use @rustbot ready when this is ready for review.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@eopb
Copy link
Contributor Author

eopb commented Dec 30, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2022
@petrochenkov
Copy link
Contributor

r? rust-lang/compiler
I'd like to take some break from reviewing.

@rustbot rustbot assigned TaKO8Ki and unassigned petrochenkov Jan 2, 2023
@estebank
Copy link
Contributor

r? @estebank
@bors r+

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit 41ee87c has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned TaKO8Ki Jan 14, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#106072 - eopb:dyn-derive, r=estebank
037b512 
fix: misleading "add dyn keyword before derive macro" suggestion

Fixes rust-lang#106071
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 14, 2023
Closed
@SmiteWindows
Copy link

@eopb src/test -> tests

@matthiaskrgr
Copy link
Member

Yes, tests have moved so this wont pass in ci
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2023
@eopb
Copy link
Contributor Author

eopb commented Jan 14, 2023

@eopb src/test -> tests

This should be fixed now.

@eopb
Copy link
Contributor Author

eopb commented Jan 14, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2023
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit 1caec6f has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 15, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 15, 2023
@bors
Auto merge of rust-lang#106892 - matthiaskrgr:rollup-ohneu8o, r=matth…
754f6d4 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106072 (fix: misleading "add dyn keyword before derive macro" suggestion)
 - rust-lang#106859 (Suggestion for type mismatch when we need a u8 but the programmer wrote a char literal)
 - rust-lang#106863 (Remove various double spaces in compiler source comments.)
 - rust-lang#106865 (Add explanation comment for GUI test)
 - rust-lang#106867 (Fix the stability attributes for `std::os::fd`.)
 - rust-lang#106878 (Add regression test for rust-lang#92157)
 - rust-lang#106879 (Add regression test for rust-lang#42114)
 - rust-lang#106880 (doc: fix typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d7fcd01 into rust-lang:master Jan 15, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 15, 2023
@eopb eopb deleted the dyn-derive branch January 15, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

misleading "add dyn keyword before derive macro" suggestion
10 participants
@eopb @rustbot @compiler-errors @rust-log-analyzer @petrochenkov @estebank @bors @SmiteWindows @matthiaskrgr @TaKO8Ki