Add explanation comment for GUI test #106865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#106072 (fix: misleading "add dyn keyword before derive macro" suggestion) - rust-lang#106859 (Suggestion for type mismatch when we need a u8 but the programmer wrote a char literal) - rust-lang#106863 (Remove various double spaces in compiler source comments.) - rust-lang#106865 (Add explanation comment for GUI test) - rust-lang#106867 (Fix the stability attributes for `std::os::fd`.) - rust-lang#106878 (Add regression test for rust-lang#92157) - rust-lang#106879 (Add regression test for rust-lang#42114) - rust-lang#106880 (doc: fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 15, 2023
…triddle Add tidy check to ensure that rustdoc GUI tests start with a small description The first commit comes from rust-lang#106865 to prevent CI to fail. This PR adds a tidy check to enforce having a small description at the top of the GUI test. Although the format is made to be as easy as possible to read, it's not always obvious what a test is actually checking. I think enforcing this will make it easier for us to come back on these tests if needed. r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @notriddle