Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect when method call on LHS might be shadowed #106150

Merged
merged 4 commits into from
Dec 27, 2022
Merged

Detect when method call on LHS might be shadowed #106150

merged 4 commits into from
Dec 27, 2022

Conversation

estebank
Copy link
Contributor

Address #39232.

@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 26, 2022
@estebank estebank mentioned this pull request Dec 26, 2022
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

Cool 🎉

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 26, 2022

📌 Commit 2cc22ce has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 27, 2022
Merged
estebank
estebank commented Dec 27, 2022
View reviewed changes
compiler/rustc_hir_typeck/src/demand.rs
Comment on lines +359 to +360
let other_methods_in_scope: Vec<_> =
in_scope_methods.iter().filter(|c| c.item.def_id != pick.item.def_id).collect();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below we should also filter out methods whose return types wouldn't can_eq with the type rhs type after dereferencing.

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2022
@bors
Auto merge of rust-lang#106177 - matthiaskrgr:rollup-oe7z8ix, r=matth…
a1fc711 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#105515 (Account for macros in const generics)
 - rust-lang#106146 (Readme: update section on how to run `x.py`)
 - rust-lang#106150 (Detect when method call on LHS might be shadowed)
 - rust-lang#106174 (Remove unused empty CSS rules in ayu theme)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e31e8b1 into rust-lang:master Dec 27, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 27, 2022
@estebank estebank deleted the issue-39232 branch November 9, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rustbot @rust-log-analyzer @compiler-errors @bors @wesleywiser