Remove unused empty CSS rules in ayu theme #106174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
camelid
reviewed
Dec 27, 2022
| @@ -183,11 +183,7 @@ individually rather than as a group) */ | |||
| /* FIXME: these rules should be at the bottom of the file but currently must be | |||
| above the `@media (max-width: 700px)` rules due to a bug in the css checker */ | |||
| /* see https://github.com/rust-lang/rust/pull/71237#issuecomment-618170143 */ | |||
| pre.rust .lifetime {} | |||
| pre.rust .kw {} | |||
| #search-tabs > button:hover, #search-tabs > button.selected {} | |||
There was a problem hiding this comment.
If we decide we should remove the rules, seems like this one should be removed too?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#105515 (Account for macros in const generics) - rust-lang#106146 (Readme: update section on how to run `x.py`) - rust-lang#106150 (Detect when method call on LHS might be shadowed) - rust-lang#106174 (Remove unused empty CSS rules in ayu theme) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Yes, they were templates made to match the other CSS file. They’re outdated because the matching rules in the other CSS files were migrated to use variables instead. That’s also why the other ones aren’t removed yet. |
|
Ah, thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @notriddle