Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Atomic*::from_ptr #108540

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Add Atomic*::from_ptr #108540

merged 2 commits into from
Mar 4, 2023

Conversation

WaffleLapkin
Copy link
Member

This PR adds functions in the following form to all atomic types:

impl AtomicT {
    pub const unsafe fn from_ptr<'a>(ptr: *mut T) -> &'a AtomicT;
}

r? @m-ou-se (we've talked about it before)

I'm not sure about docs & safety requirements, I'd appreciate some feedback on them.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 27, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-cloud-vms rust-cloud-vms bot force-pushed the atomic_thingy_from_thingy_pointer branch from 430ed83 to 4a2c555 Compare February 27, 2023 19:22
@compiler-errors

This comment was marked as resolved.

Sign in to view
@WaffleLapkin

This comment was marked as resolved.

Sign in to view
@compiler-errors

This comment was marked as resolved.

Sign in to view
@m-ou-se
Copy link
Member

m-ou-se commented Feb 28, 2023

Can you open a tracking issue? Thanks!

@WaffleLapkin WaffleLapkin mentioned this pull request Mar 2, 2023
Open
3 tasks
@WaffleLapkin
Copy link
Member Author

I've opened a tracking issue

@m-ou-se
Copy link
Member

m-ou-se commented Mar 2, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 2, 2023

📌 Commit a2baba0 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
@bors
Auto merge of rust-lang#108709 - matthiaskrgr:rollup-j2tjbyx, r=matth…
70adb4e 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104549 (add -Zexport-executable-symbols to unstable book)
 - rust-lang#108292 (Label opaque type for 'captures lifetime' error message)
 - rust-lang#108540 (Add `Atomic*::from_ptr`)
 - rust-lang#108634 (Add link to component dashboard)
 - rust-lang#108647 (Remove dead pgo.sh file)
 - rust-lang#108678 (Use `Option::as_slice` where applicable)
 - rust-lang#108681 (Improve comments in `needs_process_obligation`.)
 - rust-lang#108688 (Match unmatched backticks in library/)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 041f666 into rust-lang:master Mar 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@WaffleLapkin @rustbot @compiler-errors @m-ou-se @bors