Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comments in needs_process_obligation. #108681

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Improve comments in needs_process_obligation. #108681

merged 1 commit into from
Mar 4, 2023

Conversation

nnethercote
Copy link
Contributor

And a couple of other places.

r? @lqd

@nnethercote
Improve comments in needs_process_obligation.
3bcea5f 
And a couple of other places.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2023
@nnethercote
Copy link
Contributor Author

This shouldn't affect perf, but this function is so perf-sensitive it's worth checking.

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 2, 2023
@bors
Copy link
Contributor

bors commented Mar 2, 2023

⌛ Trying commit 3bcea5f with merge fa76d5884f66a5354a897c501352d5786e165232...

@bors
Copy link
Contributor

bors commented Mar 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
@nnethercote
Copy link
Contributor Author

That's weird: the "run the build" step on the failing machine ran for 56 minutes but a log of the output doesn't seem to be available. Maybe it's spurious.

@bors retry

@bors
Copy link
Contributor

bors commented Mar 3, 2023

⌛ Trying commit 3bcea5f with merge 6e66221e3170d0e69b109743613fddb82c643674...

@bors
Copy link
Contributor

bors commented Mar 3, 2023

☀️ Try build successful - checks-actions
Build commit: 6e66221e3170d0e69b109743613fddb82c643674 (6e66221e3170d0e69b109743613fddb82c643674)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6e66221e3170d0e69b109743613fddb82c643674): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.5% [3.5%, 3.5%] 1
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 3, 2023
@nnethercote
Copy link
Contributor Author

No perf changes, as expected.

@bors rollup=always

@lqd
Copy link
Member

lqd commented Mar 3, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 3, 2023

📌 Commit 3bcea5f has been approved by lqd

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 3, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 3, 2023
@matthiaskrgr
Rollup merge of rust-lang#108681 - nnethercote:needs_process_obligati…
507a6cf 
…on-comments, r=lqd

Improve comments in `needs_process_obligation`.

And a couple of other places.

r? `@lqd`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 3, 2023
Closed
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr matthiaskrgr mentioned this pull request Mar 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
@bors
Auto merge of rust-lang#108709 - matthiaskrgr:rollup-j2tjbyx, r=matth…
70adb4e 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104549 (add -Zexport-executable-symbols to unstable book)
 - rust-lang#108292 (Label opaque type for 'captures lifetime' error message)
 - rust-lang#108540 (Add `Atomic*::from_ptr`)
 - rust-lang#108634 (Add link to component dashboard)
 - rust-lang#108647 (Remove dead pgo.sh file)
 - rust-lang#108678 (Use `Option::as_slice` where applicable)
 - rust-lang#108681 (Improve comments in `needs_process_obligation`.)
 - rust-lang#108688 (Match unmatched backticks in library/)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 37bd50e into rust-lang:master Mar 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 4, 2023
@nnethercote nnethercote deleted the needs_process_obligation-comments branch March 6, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nnethercote @rust-timer @bors @lqd @rust-log-analyzer @rustbot