Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ObligationCtxt::sub #108750

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix ObligationCtxt::sub #108750

merged 1 commit into from
Mar 7, 2023

Conversation

compiler-errors
Copy link
Member

typo it seems

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2023

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

@lcnr
Copy link
Contributor

lcnr commented Mar 6, 2023 •
edited
Loading

that's kinda bad, how did no test catch that 🤔

r=me with a test which breaks because of that. Trying to write one myself rn

@lcnr
Copy link
Contributor

lcnr commented Mar 6, 2023 •
edited
Loading

alright, so ObligationCtxt::sub was only used in fn is_subtype which is mostly only used by the mir validator. While there are probably some ways to get an ice here, searching for them is annoying and takes time

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 6, 2023

📌 Commit 1f92c61 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#108750 - compiler-errors:aaaaaaaa, r=lcnr
c6e4100 
Fix `ObligationCtxt::sub`

typo it seems
This was referenced Mar 6, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2023
@bors
Auto merge of rust-lang#108821 - matthiaskrgr:rollup-cmkbgpr, r=matth…
81be7b8 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107801 (const_eval: `implies_by` in `rustc_const_unstable`)
 - rust-lang#108750 (Fix `ObligationCtxt::sub`)
 - rust-lang#108780 (Add regression tests for issue 70919)
 - rust-lang#108786 (Check for free regions in MIR validation)
 - rust-lang#108790 (Do not ICE when interpreting a cast between non-monomorphic types)
 - rust-lang#108803 (Do not ICE when failing to normalize in ConstProp.)
 - rust-lang#108807 (Emit the suspicious_auto_trait_impls for negative impls as well)
 - rust-lang#108812 (Add regression test for rust-lang#98444)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6240b54 into rust-lang:master Mar 7, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 7, 2023
@lukas-code lukas-code mentioned this pull request Apr 3, 2023
Closed
@compiler-errors compiler-errors deleted the aaaaaaaa branch August 11, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @lcnr @bors @wesleywiser