Change tidy error message for TODOs #109444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
|
#109440 has been merged, so this is unblocked :) |
jyn514
reviewed
Apr 26, 2023
jyn514
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
undeprecate_todos
branch
from
2397447
to
52a53a7
Compare
rustbot
added
the
T-bootstrap
rust-cloud-vms
bot
force-pushed
the
undeprecate_todos
branch
from
52a53a7
to
b311ec0
Compare
|
@rustbot ready I'm still a bit iffy about the exact messages, but I've rebased the PR + fixed messages according to the comments above. |
rustbot
added
S-waiting-on-review
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#108760 (Add lint to deny diagnostics composed of static strings) - rust-lang#109444 (Change tidy error message for TODOs) - rust-lang#110419 (Spelling library) - rust-lang#110550 (Suggest deref on comparison binop RHS even if type is not Copy) - rust-lang#110641 (Add new rustdoc book chapter to describe in-doc settings) - rust-lang#110798 (pass `unused_extern_crates` in `librustdoc::doctest::make_test`) - rust-lang#110819 (simplify TrustedLen impls) - rust-lang#110825 (diagnostics: add test case for already-solved issue) - rust-lang#110835 (Make some region folders a little stricter.) - rust-lang#110847 (rustdoc-json: Time serialization.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #109440 (first few commits are from where)
IMO "deprecated" doesn't really explain anything, I've tried to highlight the actual reason we error on TODOs. The message is not at all perfect, maybe someone has ideas how to phrase it better?