Rollup of 10 pull requests #110852
Merged
Rollup of 10 pull requests #110852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <work@onurozkan.dev>
Implement on FlattenCompat and delegate from Flatten and FlatMap.
Because certain regions cannot occur in them.
* advance * aligned * borrowed * calculate * debugable * debuggable * declarations * desugaring * documentation * enclave * ignorable * initialized * iterator * kaboom * monomorphization * nonexistent * optimizer * panicking * process * reentrant * rustonomicon * the * uninitialized Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…iser
Add lint to deny diagnostics composed of static strings
r? ghost
I'm hoping to have a lint that semi-automatically converts simple diagnostics such as `struct_span_err(span, "msg").help("msg").span_note(span2, "msg").emit()` to typed session diagnostics. It's quite hacky and not entirely working because of problems with `x fix` but should hopefully help reduce some of the work.
I'm going to start trying to apply what I can from this, but opening this as a draft in case anyone wants to develop on it.
cc rust-lang#100717
…jyn514 Change tidy error message for TODOs Blocked on rust-lang#109440 (first few commits are from where) IMO "deprecated" doesn't really explain anything, I've tried to highlight the actual reason we error on TODOs. The message is not at all perfect, maybe someone has ideas how to phrase it better?
Spelling library Split per rust-lang#110392 I can squash once people are happy w/ the changes. It's really uncommon for large sets of changes to be perfectly acceptable w/o at least some changes. I probably won't have time to respond until tomorrow or the next day
…, r=wesleywiser Suggest deref on comparison binop RHS even if type is not Copy Fixes rust-lang#110500
…ings, r=notriddle Add new rustdoc book chapter to describe in-doc settings Fixes rust-lang#55165. I continue going through old rustdoc issues. This one made a lot of sense so decided to add the missing chapter. r? ``@notriddle``
…ates, r=jyn514 pass `unused_extern_crates` in `librustdoc::doctest::make_test` blocker for rust-lang#106621
…=the8472 simplify TrustedLen impls Implement on FlattenCompat and delegate from Flatten and FlatMap. /cc ``@the8472``
…=compiler-errors diagnostics: add test case for already-solved issue Fixes rust-lang#70082
…2, r=compiler-errors Make some region folders a little stricter. Because certain regions cannot occur in them. r? ``@compiler-errors``
…on, r=GuillaumeGomez
rustdoc-json: Time serialization.
This lets us know how much time is spent in json specific code, and how much performance we could gain by using a different serialization format.
For aws-sdk-ec2, it takes 0.7s, out of a 43s build (of which 6s is spent in json specific code), and makes a 173M json file
```
$ cargo +rust_stage2 rustdoc -p aws-sdk-ec2 -- -Zunstable-options -w json -Ztime-passes
Documenting aws-sdk-ec2 v0.26.0 (/home/gh-aDotInTheVoid/aws-sdk-rust/sdk/ec2)
time: 5.229; rss: 64MB -> 891MB ( +827MB) expand_crate
time: 5.230; rss: 61MB -> 891MB ( +830MB) macro_expand_crate
time: 0.256; rss: 891MB -> 891MB ( +0MB) AST_validation
time: 0.025; rss: 891MB -> 891MB ( +1MB) finalize_imports
time: 0.093; rss: 891MB -> 891MB ( +0MB) compute_effective_visibilities
time: 0.122; rss: 891MB -> 891MB ( +0MB) finalize_macro_resolutions
time: 2.442; rss: 891MB -> 1188MB ( +297MB) late_resolve_crate
time: 0.120; rss: 1188MB -> 1190MB ( +2MB) resolve_check_unused
time: 0.211; rss: 1190MB -> 1190MB ( +0MB) resolve_postprocess
time: 3.017; rss: 891MB -> 1190MB ( +299MB) resolve_crate
time: 8.520; rss: 61MB -> 1181MB (+1120MB) prepare_outputs
time: 0.152; rss: 1181MB -> 1181MB ( +0MB) complete_gated_feature_checking
time: 0.539; rss: 1633MB -> 1632MB ( -1MB) drop_ast
time: 15.492; rss: 58MB -> 1621MB (+1563MB) type_collecting
time: 1.503; rss: 1621MB -> 1705MB ( +84MB) item_types_checking
time: 1.274; rss: 1705MB -> 1726MB ( +21MB) crate_lints
time: 1.275; rss: 1705MB -> 1726MB ( +21MB) missing_docs
time: 0.281; rss: 1726MB -> 1726MB ( +0MB) check_mod_attrs
time: 0.433; rss: 1744MB -> 1750MB ( +6MB) clean_crate
time: 11.581; rss: 1750MB -> 2107MB ( +357MB) collect_synthetic_impls
time: 0.019; rss: 2107MB -> 2107MB ( +0MB) collect_items_for_trait_impls
time: 12.588; rss: 1750MB -> 2139MB ( +389MB) collect-trait-impls
time: 0.197; rss: 2139MB -> 2139MB ( +0MB) check_doc_test_visibility
time: 0.281; rss: 2139MB -> 2150MB ( +11MB) strip-hidden
time: 0.260; rss: 2150MB -> 2150MB ( +0MB) strip-private
warning: unresolved link to `date`
--> sdk/ec2/src/client/describe_instances.rs:7:11184
|
7 | ...te of the instance (for example, shows "User Initiated [date]" when you stop or terminate the instance). Similar to the state-reason-code filter.<...
| ^^^^ no item named `date` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
= note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
time: 0.363; rss: 2150MB -> 2150MB ( +0MB) collect-intra-doc-links
time: 0.946; rss: 2150MB -> 2150MB ( +0MB) propagate-doc-cfg
time: 0.494; rss: 2150MB -> 2152MB ( +2MB) run-lints
time: 0.658; rss: 2152MB -> 2163MB ( +11MB) create_format_cache
time: 34.818; rss: 58MB -> 2163MB (+2105MB) run_global_ctxt
time: 0.016; rss: 2163MB -> 2163MB ( +0MB) create_renderer(json)
time: 0.723; rss: 2780MB -> 2780MB ( +0MB) rustdoc_json_serialization
time: 2.216; rss: 2399MB -> 2599MB ( +199MB) renderer_after_krate(json)
time: 6.639; rss: 2163MB -> 2417MB ( +254MB) render_json
time: 0.312; rss: 2417MB -> 2071MB ( -346MB) free_global_ctxt
warning: `aws-sdk-ec2` (lib doc) generated 1 warning
Finished dev [unoptimized + debuginfo] target(s) in 43.06s
```
[(Zulip Discussion)](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/JSON.20metadata.20speed/near/352783145)
r? `@GuillaumeGomez`
rustbot
added
A-rustdoc-json
rustbot
added
WG-trait-system-refactor
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 9c044d77a3 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 26, 2023
|
Finished benchmarking commit (1c42cb4): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
unused_extern_cratesinlibrustdoc::doctest::make_test#110798 (passunused_extern_cratesinlibrustdoc::doctest::make_test)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup