Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tcp): change a hardcoded port number in a doctest to port var #109995

Merged
merged 2 commits into from
Apr 8, 2023
Merged

chore(tcp): change a hardcoded port number in a doctest to port var #109995

merged 2 commits into from
Apr 8, 2023

Conversation

enkron
Copy link
Contributor

@enkron enkron commented Apr 6, 2023

The listen_on function in the example has a port option but doesn't use it

@enkron
chore(tcp): change the hardcoded port number to port var
502cb6f 
The `listen_on` function in the example has a `port` option but doesn't
use it
@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@jyn514
Copy link
Member

jyn514 commented Apr 6, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 6, 2023

📌 Commit 502cb6f has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2023
@jyn514 jyn514 changed the title chore(tcp): change the hardcoded port number to port var chore(tcp): change a hardcoded port number in a doctest to port var Apr 6, 2023
the8472
the8472 reviewed Apr 7, 2023
View reviewed changes
library/std/src/net/tcp.rs Outdated Show resolved Hide resolved
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Apr 7, 2023
@Noratrieb
Rollup merge of rust-lang#109995 - enkron:u/enkron/substitute-hardcod…
9490998 
…ed-port-num-in-listen-on-fn, r=jyn514

chore(tcp): change a hardcoded port number in a doctest to `port` var

The `listen_on` function in the example has a `port` option but doesn't use it
This was referenced Apr 7, 2023
Closed
Closed
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Apr 7, 2023
@Noratrieb
Rollup merge of rust-lang#109995 - enkron:u/enkron/substitute-hardcod…
33c6e08 
…ed-port-num-in-listen-on-fn, r=jyn514

chore(tcp): change a hardcoded port number in a doctest to `port` var

The `listen_on` function in the example has a `port` option but doesn't use it
@the8472
Copy link
Member

the8472 commented Apr 8, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2023

📌 Commit 081e222 has been approved by the8472

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 8, 2023

⌛ Testing commit 081e222 with merge c49c4fb...

@bors
Copy link
Contributor

bors commented Apr 8, 2023

☀️ Test successful - checks-actions
Approved by: the8472
Pushing c49c4fb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 8, 2023
@bors bors merged commit c49c4fb into rust-lang:master Apr 8, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 8, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c49c4fb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.8% [2.4%, 3.3%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.8% [2.4%, 3.3%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@enkron enkron deleted the u/enkron/substitute-hardcoded-port-num-in-listen-on-fn branch April 10, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 left review comments

Assignees

@joshtriplett joshtriplett

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
7 participants
@enkron @rustbot @jyn514 @bors @the8472 @rust-timer @joshtriplett