Rollup of 5 pull requests #110053
Closed
Rollup of 5 pull requests #110053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… LLVMValueRef, some that accept LLVMMetadataRef, and replacing one with another not always possible without explicit convertion
… LLVMRustMetadataTypeInContext with LLVMMetadataTypeInContext
LLVMRustBuildCleanupPad -> LLVMBuildCleanupPad LLVMRustBuildCleanupRet -> LLVMBuildCleanupRet LLVMRustBuildCatchPad -> LLVMBuildCatchPad LLVMRustBuildCatchRet -> LLVMBuildCatchRet LLVMRustBuildCatchSwitch -> LLVMBuildCatchSwitch
Turns out - `owning_ref` is unsound due to `Box` aliasing stuff - `rustc` doesn't need 99% of the `owning_ref` API - `rustc` can use a far simpler abstraction that is `OwnedSlice`
The `listen_on` function in the example has a `port` option but doesn't use it
…n-trait, r=petrochenkov More descriptive error when qself path doesnt have a trait on the RHS of `as` `<Ty as Enum>::Assoc` should report that `Enum` is a trait. Main question is whether to eagerly report the error, or raise it with `return Err(..)` -- i'll note that in an inline comment though. cc `@GuillaumeGomez` who said this came up at a Paris Rust meetup. r? `@petrochenkov`
llvm: replace some deprecated functions, add fixmes Replace some deprecated llvm functions, add FIXME's (for simpler future work), replace some rust custom functions with llvm ones.
…strieb Yeet `owning_ref` Based on the discussions from rust-lang#109948 This replaces `owning_ref` with a far simpler & safer abstraction. Fixes rust-lang#109974
…ed-port-num-in-listen-on-fn, r=jyn514 chore(tcp): change a hardcoded port number in a doctest to `port` var The `listen_on` function in the example has a `port` option but doesn't use it
… r=GuillaumeGomez rustdoc: add test and bug fix for theme defaults Part of rust-lang#66181
rustbot
added
S-waiting-on-review
|
...thanks bors for opening two PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
as#109788 (More descriptive error when qself path doesnt have a trait on the RHS ofas)owning_ref#109971 (Yeetowning_ref)portvar #109995 (chore(tcp): change a hardcoded port number in a doctest toportvar)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup