-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Fluent messages are in alphabetical order #111858
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo |
0d48ded
to
08a6965
Compare
This comment has been minimized.
This comment has been minimized.
Looks fine... cc @rust-lang/wg-diagnostics in case anyone else cares, but I generally agree that, since ftl files otherwise have literally no structure except for generally being chronologically ordered, they probably should be just alphabetical. |
Should we stick your fmt script into |
tidy already has a |
08a6965
to
a6e1ef9
Compare
a6e1ef9
to
e74a08a
Compare
This comment has been minimized.
This comment has been minimized.
e74a08a
to
f97fdda
Compare
@bors r=jyn514,compiler-errors |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c86212f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 644.952s -> 644.366s (-0.09%) |
Fixes #111847
This adds a tidy check to ensure Fluent messages are in alphabetical order, as well as sorting all existing messages. I think the error could be worded better, would appreciate suggestions.
Script used to sort files